From: MON KEY <monkey@sandpframing.com>
To: 7518@debbugs.gnu.org
Subject: bug#7518: image-dired defcustom'd paths
Date: Mon, 29 Nov 2010 19:40:59 -0500 [thread overview]
Message-ID: <AANLkTin0XqoguJY_hCnKP-cUF9zGfqp9joErxU85ZY3f@mail.gmail.com> (raw)
current through bzr revision 102504
Now that ImageMagick libs are accessble to Emacs24 maybe more users
will be using image-dired.
The defcustom form for variables
`image-dired-dir',
`image-dired-db-file',
`image-dired-temp-image-file',
`image-dired-gallery-dir'
`image-dired-temp-rotate-image-file',
each evaluate `locate-user-emacs-file' when binding their default path
values.
There is something wrong about this.
AFAIK `image-dired' isn't loaded by default. Why should _each_ of
these variables elevate to creation of a `user-emacs-directory'
if/when one doesn't already exit? By the time (require 'image-dired)
gets evaluated shouldnt' `user-emacs-directory' already be well
established?
At best only `image-dired-dir' should need to to this and even then it
is suspect. Maybe the rest of the do somethign more like:
(make-directory
(expand-file-name "some/path-for/image-dired-var" image-dired-dir))
or, respectively:
(make-directory
(expand-file-name "some/path-for/image-dired-var" image-dired-dir) t)
Also, w/re those of the above variables which bind directory paths for
a temporary files, e.g.:
`image-dired-temp-image-file' and `image-dired-temp-rotate-image-file'
Why not just use `temporary-file-directory' and/or
`small-temporary-file-directory' as the base paths?
--
/s_P\
next reply other threads:[~2010-11-30 0:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-30 0:40 MON KEY [this message]
2010-12-05 1:05 ` bug#7518: image-dired defcustom'd paths Chong Yidong
2010-12-06 0:56 ` MON KEY
2010-12-06 19:47 ` Chong Yidong
2010-12-07 2:49 ` MON KEY
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTin0XqoguJY_hCnKP-cUF9zGfqp9joErxU85ZY3f@mail.gmail.com \
--to=monkey@sandpframing.com \
--cc=7518@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.