From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-23 r99841: * minibuf.c (Fall_completions): Add more checks. Date: Tue, 8 Jun 2010 22:03:52 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276027468 23373 80.91.229.12 (8 Jun 2010 20:04:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 8 Jun 2010 20:04:28 +0000 (UTC) Cc: Emacs developers To: Andreas Schwab Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 08 22:04:24 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OM527-0005rC-N5 for ged-emacs-devel@m.gmane.org; Tue, 08 Jun 2010 22:04:24 +0200 Original-Received: from localhost ([127.0.0.1]:42906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM526-0000qp-BV for ged-emacs-devel@m.gmane.org; Tue, 08 Jun 2010 16:04:22 -0400 Original-Received: from [140.186.70.92] (port=44880 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OM520-0000q5-7z for emacs-devel@gnu.org; Tue, 08 Jun 2010 16:04:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OM51y-0008Jj-70 for emacs-devel@gnu.org; Tue, 08 Jun 2010 16:04:15 -0400 Original-Received: from mail-fx0-f41.google.com ([209.85.161.41]:47998) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OM51y-0008J5-2F for emacs-devel@gnu.org; Tue, 08 Jun 2010 16:04:14 -0400 Original-Received: by fxm14 with SMTP id 14so3705701fxm.0 for ; Tue, 08 Jun 2010 13:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=02CHl8hj4laINSy0Rfc1kGuI4qWEYZlv9PMIDPANGi4=; b=NGD+d6H+4Zmkkx6sgoyX1hv/c70ofbMhyA8nbjoi/czPUI/I99bJXQ06XlGVG6tBd5 P200i8jsbeqALcUtl7aPz38Z1ObHbCBhNs6PqL4NjtzhsmM5WNMg1dJtz5VjiLHl2FLq w9OFSPVaTMdl0rqsFx4rvAnGXe5EF96Is7Nmw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=Dg/5Q5l/5S4QsOjDbQcQkVjZlRV6KSOWsA1vew97oSC2Ek3tVuNhFUfWGxt/6b4vrb y7hPHYol6f2nyW2yYZxXXiVs30GCQuxQ+YsqkQeUpEW8EtuFKpK1Tzf3NIVxgbZx6tb2 GfArXeK4NdTj3x3mm/+fgbzoFzGlteb1KXaI8= Original-Received: by 10.204.81.222 with SMTP id y30mr1141443bkk.155.1276027452249; Tue, 08 Jun 2010 13:04:12 -0700 (PDT) Original-Received: by 10.204.32.5 with HTTP; Tue, 8 Jun 2010 13:03:52 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125638 Archived-At: On Tue, Jun 8, 2010 at 19:56, Andreas Schwab wrote: > - =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (!EQ (bucket, zero)) > + =C2=A0 =C2=A0 =C2=A0 =C2=A0 if (SYMBOLP (bucket)) This is different than passing [] (which is a valid, if empty, obarray). According to docs: [...] an obarray is actually a vector. Each element of the vector is a bucket; its value is either an interned symbol whose name hashes to that bucket, or 0 if the bucket is empty. So [3] is not a valid obarray, so (all-completions "" [3]) should throw an error, not return nil. Juanma