all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: [Emacs-diffs] /srv/bzr/emacs/emacs-23 r99841: * minibuf.c  (Fall_completions): Add more checks.
       [not found] <E1OM3Mp-0000Nr-G4@internal.in.savannah.gnu.org>
@ 2010-06-08 20:03 ` Juanma Barranquero
  0 siblings, 0 replies; only message in thread
From: Juanma Barranquero @ 2010-06-08 20:03 UTC (permalink / raw
  To: Andreas Schwab; +Cc: Emacs developers

On Tue, Jun 8, 2010 at 19:56, Andreas Schwab <schwab@linux-m68k.org> wrote:

> -         if (!EQ (bucket, zero))
> +         if (SYMBOLP (bucket))

This is different than passing [] (which is a valid, if empty,
obarray). According to docs:

  [...] an obarray is actually a vector.  Each element of the
  vector is a bucket; its value is either an interned symbol whose name
  hashes to that bucket, or 0 if the bucket is empty.

So [3] is not a valid obarray, so (all-completions "" [3]) should
throw an error, not return nil.

    Juanma



^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2010-06-08 20:03 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <E1OM3Mp-0000Nr-G4@internal.in.savannah.gnu.org>
2010-06-08 20:03 ` [Emacs-diffs] /srv/bzr/emacs/emacs-23 r99841: * minibuf.c (Fall_completions): Add more checks Juanma Barranquero

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.