From: Juanma Barranquero <lekktu@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Emacs developers <emacs-devel@gnu.org>
Subject: Re: [Emacs-diffs] /srv/bzr/emacs/emacs-23 r99841: * minibuf.c (Fall_completions): Add more checks.
Date: Tue, 8 Jun 2010 22:03:52 +0200 [thread overview]
Message-ID: <AANLkTimzJtPzWoD2Sf_S2X5vLOLmReslRCk94jSoGub9@mail.gmail.com> (raw)
In-Reply-To: <E1OM3Mp-0000Nr-G4@internal.in.savannah.gnu.org>
On Tue, Jun 8, 2010 at 19:56, Andreas Schwab <schwab@linux-m68k.org> wrote:
> - if (!EQ (bucket, zero))
> + if (SYMBOLP (bucket))
This is different than passing [] (which is a valid, if empty,
obarray). According to docs:
[...] an obarray is actually a vector. Each element of the
vector is a bucket; its value is either an interned symbol whose name
hashes to that bucket, or 0 if the bucket is empty.
So [3] is not a valid obarray, so (all-completions "" [3]) should
throw an error, not return nil.
Juanma
parent reply other threads:[~2010-06-08 20:03 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <E1OM3Mp-0000Nr-G4@internal.in.savannah.gnu.org>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTimzJtPzWoD2Sf_S2X5vLOLmReslRCk94jSoGub9@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.