From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Key Newsgroups: gmane.emacs.devel Subject: Bar Cursor Still To Narrow on Mac OS X Date: Sat, 5 Mar 2011 17:41:52 -0600 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=000325558cb2ca875b049dc4cf77 X-Trace: dough.gmane.org 1299368545 4756 80.91.229.12 (5 Mar 2011 23:42:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 5 Mar 2011 23:42:25 +0000 (UTC) To: Emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Mar 06 00:42:21 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pw177-0001sd-9A for ged-emacs-devel@m.gmane.org; Sun, 06 Mar 2011 00:42:21 +0100 Original-Received: from localhost ([127.0.0.1]:45705 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pw176-0002ki-KA for ged-emacs-devel@m.gmane.org; Sat, 05 Mar 2011 18:42:20 -0500 Original-Received: from [140.186.70.92] (port=42035 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pw171-0002kT-6P for Emacs-devel@gnu.org; Sat, 05 Mar 2011 18:42:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pw170-0001qL-4I for Emacs-devel@gnu.org; Sat, 05 Mar 2011 18:42:15 -0500 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:39309) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pw16z-0001q0-Qt for Emacs-devel@gnu.org; Sat, 05 Mar 2011 18:42:14 -0500 Original-Received: by bwz17 with SMTP id 17so3435879bwz.0 for ; Sat, 05 Mar 2011 15:42:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:from:date:message-id:subject:to :content-type; bh=iEsPw1+oYrcU+vZsslJ3cSZa9HYtfkKMeJQfZo7W1W4=; b=NWpXxi7OiTY2NW2AWkDD9LJqmp+wiTiOGIvvkfoK8SxhoPXr7xl2i+XieQYJ1wpunn Ukd2oBr7o1DLJ8GUXncHo5hN/Ssx5kUgWzG/+ei+O1bP/8KpHFPE1dHtwZRbIG0r7HZj yWR6klXOqYLesM8We3CuXX3wiFuPejs+XzUy0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=qKUyX9++U12x/uPe3f99fnDyHhr9pXGTyt07vZNrmGwgyOVi0TrvcigWnc4n6fo1sh Dj+nX8DMbtpR9C5iTRyM3d/um9jpVLnDPiw+nLLfFsChNbyCpQ/LEfmM14W3/K12wdya AhbfE04ev/S+CmyU7TOS1ag2OY9sRqg13r94c= Original-Received: by 10.204.25.9 with SMTP id x9mr1966812bkb.82.1299368532149; Sat, 05 Mar 2011 15:42:12 -0800 (PST) Original-Received: by 10.204.14.212 with HTTP; Sat, 5 Mar 2011 15:41:52 -0800 (PST) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136798 Archived-At: --000325558cb2ca875b049dc4cf77 Content-Type: text/plain; charset=ISO-8859-1 Hello, Some time ago I reported a bug in Emacs that caused the bar cursor to be too narrow in the Mac OS X version of Emacs. I also submitted a patch to fix the problem. This problem was supposedly fixed in revision 103406 by Chong Yidong. The problem is that this change did not fix the problem. In fact it made it worse. The original problem was based on a line of code that effectively caused the user selected value for the Bar Cursor to be completely ignored. This line was as follows. s.size.width = min (cursor_width, 2); //FIXME(see above) This line caused the cursor width to be set to 2 even if the user requested cursor width was a value higher than 2. The problem is that in the change made by Chong Yidong, there is a similar line that has the same effect of causing the user specified value for the cursor width to be ignored. This line is as follows. cursor_width = min (cursor_width, 1); The end result of this line is that now the user specified value for cursor width is still ignored and instead the value 1 is used as the cursor width. So now when the user requests that Emacs use a 4 pixel wide bar cursor, they get a 1 pixel wide bar cursor. Personally I preferred the 2 pixel wide cursor that was displayed before the change made in revision 103406. What I would prefer even more would be for Emacs to NOT ignore the user requested value for cursor width. I am once again submitting a patch that fixes this problem. This patch simply removes the offending line from nsterm.m. === modified file 'src/nsterm.m' --- src/nsterm.m 2011-03-03 08:03:01 +0000 +++ src/nsterm.m 2011-03-05 23:32:39 +0000 @@ -2284,7 +2284,6 @@ { if (cursor_width < 0) cursor_width = FRAME_CURSOR_WIDTH (f); - cursor_width = min (cursor_width, 1); w->phys_cursor_width = cursor_width; } Please commit this patch. --000325558cb2ca875b049dc4cf77 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

Some time ago I reported a bug in Emacs that= caused the bar cursor to be too narrow in the Mac OS X version of Emacs.= =A0 I also submitted a patch to fix the problem.=A0 This problem was suppos= edly fixed in revision 103406 by Chong Yidong.=A0 The problem is that this = change did not fix the problem.=A0 In fact it made it worse.

The original problem was based on a line of code that effectively cause= d the user selected value for the Bar Cursor to be completely ignored.=A0 T= his line was as follows.
=A0=A0=A0=A0 s.size.width =3D min (cursor_width= , 2); //FIXME(see above)

This line caused the cursor width to be set to 2 even if the user reque= sted cursor width was a value higher than 2.

The problem is that in = the change made by Chong Yidong, there is a similar= line that has the same effect of causing the user specified value for the = cursor width to be ignored.=A0 This line is as follows.
=A0=A0=A0=A0=A0 cursor_width =3D min (cursor_width, 1);

The end resu= lt of this line is that now the user specified value for cursor width is st= ill ignored and instead the value 1 is used as the cursor width.=A0 So now = when the user requests that Emacs use a 4 pixel wide bar cursor, they get a= 1 pixel wide bar cursor.=A0 Personally I preferred the 2 pixel wide cursor= that was displayed before the change made <= font size=3D"4">in revision 103406.=A0 What I would prefer even more would = be for Emacs to NOT ignore the user requested value for cursor width.

I am once again submitting a patch that fixes this problem.=A0 This pat= ch simply removes the offending line from nsterm.m.

<patch>=3D=3D=3D modified file 'src/nsterm.m'
--- src/nsterm.m=A0=A0= =A0 2011-03-03 08:03:01 +0000
+++ src/nsterm.m=A0=A0=A0 2011-03-05 23:32:39 +0000
@@ -2284,7 +2284,6 @= @
=A0=A0=A0=A0 {
=A0=A0=A0=A0=A0=A0 if (cursor_width < 0)
=A0= =A0=A0=A0 cursor_width =3D FRAME_CURSOR_WIDTH (f);
-=A0=A0=A0=A0=A0 curs= or_width =3D min (cursor_width, 1);
=A0=A0=A0=A0=A0=A0 w->phys_cursor= _width =3D cursor_width;
=A0=A0=A0=A0 }
=A0

</patch>

Please commit this patch= .

--000325558cb2ca875b049dc4cf77--