bug#7749: Buffer Menu forgets which buffers it has

bug#7749: Buffer Menu forgets which buffers it has

[Lennart Borgman]

Create a buffer menu buffer with

  (display-buffer
    (list-buffers-noselect nil (list (current-buffer))))

The list will have just one buffer.

Click on a column in the header to sort the list of buffers. After
this the list will show all buffers that the user normally sees.


GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-12-15

bug#7749: Buffer Menu forgets which buffers it has

[Lennart Borgman]

[-- Attachment #1: Type: text/plain, Size: 427 bytes --]

On Tue, Dec 28, 2010 at 9:53 AM, Lennart Borgman
<lennart.borgman@gmail.com> wrote:
> Create a buffer menu buffer with
>
>  (display-buffer
>    (list-buffers-noselect nil (list (current-buffer))))
>
> The list will have just one buffer.
>
> Click on a column in the header to sort the list of buffers. After
> this the list will show all buffers that the user normally sees.

Attached a patch that fixes this.

[-- Attachment #2: buff-menu-revert.diff --]
[-- Type: application/octet-stream, Size: 1361 bytes --]

=== modified file 'lisp/buff-menu.el'
--- trunk/lisp/buff-menu.el	2010-11-09 05:33:07 +0000
+++ patched/lisp/buff-menu.el	2010-12-28 22:11:57 +0000
@@ -116,6 +116,14 @@
 
 (make-variable-buffer-local 'Buffer-menu-files-only)
 
+(defvar Buffer-menu-current-buffers nil
+  "Non-nil if the current buffer-menu lists only those buffers.
+This variable determines whether reverting the buffer lists only
+this buffers.  It affects both manual reverting and reverting by
+Auto Revert Mode.")
+
+(make-variable-buffer-local 'Buffer-menu-current-buffers)
+
 (defvar Info-current-file) ;; from info.el
 (defvar Info-current-node) ;; from info.el
 
@@ -283,7 +291,7 @@
     ;; interactively current buffer is correctly identified with a `.'
     ;; by `list-buffers-noselect'.
     (with-current-buffer (window-buffer)
-      (list-buffers-noselect Buffer-menu-files-only))
+      (list-buffers-noselect Buffer-menu-files-only Buffer-menu-current-buffers))
     (if oline
 	(while (setq prop (next-single-property-change prop 'buffer))
 	  (when (eq (get-text-property prop 'buffer) oline)
@@ -920,6 +928,7 @@
       (and desired-point
 	   (goto-char desired-point))
       (setq Buffer-menu-files-only files-only)
+      (setq Buffer-menu-current-buffers buffer-list)
       (set-buffer-modified-p nil)
       (current-buffer))))
 

bug#7749: Buffer Menu forgets which buffers it has

[Chong Yidong]

Lennart Borgman <lennart.borgman@gmail.com> writes:

>> (display-buffer
>>   (list-buffers-noselect nil (list (current-buffer))))
>>
>> The list will have just one buffer.
>>
>> Click on a column in the header to sort the list of buffers. After
>> this the list will show all buffers that the user normally sees.
>
> Attached a patch that fixes this.

Thanks, this looks correct.  Committed to the emacs-23 branch.