From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?UTF-8?Q?Jordi_Guti=C3=A9rrez_Hermoso?= Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] let octave-mode understand single-quoted strings Date: Tue, 31 Aug 2010 16:15:39 -0500 Message-ID: References: <4C02D67D.5090302@censorshipresearch.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1283290070 7460 80.91.229.12 (31 Aug 2010 21:27:50 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 Aug 2010 21:27:50 +0000 (UTC) Cc: Daniel Colascione , Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 31 23:27:46 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OqYMr-0002o6-PD for ged-emacs-devel@m.gmane.org; Tue, 31 Aug 2010 23:27:46 +0200 Original-Received: from localhost ([127.0.0.1]:42544 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqYMr-0008HB-7u for ged-emacs-devel@m.gmane.org; Tue, 31 Aug 2010 17:27:45 -0400 Original-Received: from [140.186.70.92] (port=59861 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OqYLn-0007Ay-Hp for emacs-devel@gnu.org; Tue, 31 Aug 2010 17:26:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OqYBB-0000lT-Uz for emacs-devel@gnu.org; Tue, 31 Aug 2010 17:15:46 -0400 Original-Received: from mail-wy0-f169.google.com ([74.125.82.169]:56104) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OqYBB-0000l6-KL for emacs-devel@gnu.org; Tue, 31 Aug 2010 17:15:41 -0400 Original-Received: by wyb36 with SMTP id 36so10232951wyb.0 for ; Tue, 31 Aug 2010 14:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type; bh=AvtqI2pcvVT94GRAqwcxd1kKnBgBxT4XNBBEPHBWJX8=; b=aeLk7NlnkKUPX7r7Bqab2TIfdAuZ1bFJkBtsM9pt5U3DJv0ro7obeTERuKqZhXwT5x LVcPd0YJKtCnCxRMy9pHiMyWqQPbQrUffaR1K02Maugu0ci7C1Jc6++L84j0z+E+Ax0j L8iYAVbfRwtBG/NuWc9X3oraeTyFo/H/+GdtY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=wQFiLJ2w74wJqDY/P3KeTYbzV1GJYPOjspuuXo3C1omuvljOs5uuv1tr1ysFtUZ2wk olqfYolcHBlZYNwh1yPR9fc7oxaLSQbbAcIp+oMwouBRgViSUs0HydNi27J+AT6j9Dct g3iN4Wbg7h9uu4E9pVFWHWyDuhD0BmOkG6pB4= Original-Received: by 10.227.132.199 with SMTP id c7mr7310343wbt.89.1283289339892; Tue, 31 Aug 2010 14:15:39 -0700 (PDT) Original-Received: by 10.216.137.202 with HTTP; Tue, 31 Aug 2010 14:15:39 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:129513 Archived-At: Hi, I worked with Daniel on this patch. I'm a frequent Octave user and so far casual contributor. On 31 August 2010 07:32, Stefan Monnier wrote: > I'm not familiar with Octave, so your code might be more correct in > some cases, OTOH my code handles multi-line strings. Do you think we > should try and get the best of both worlds, or should we replace my > code with yours, or should we just stick with my code? Daniel's code is correct in several cases I tried, so I would recommend it. I don't know what you may have done with multiline strings, but they seem to work just as well. Of course it would be nice if both features worked. Octave mode still requires a lot of work in other directions. Octave syntax has been enriched somewhat since the mode was first written. With time I may be able to provide these necessary patches myself. - Jordi G. H.