all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Jordi Gutiérrez Hermoso" <jordigh@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Daniel Colascione <daniel@censorshipresearch.org>,
	Emacs development discussions <emacs-devel@gnu.org>
Subject: Re: [PATCH] let octave-mode understand single-quoted strings
Date: Tue, 31 Aug 2010 16:15:39 -0500	[thread overview]
Message-ID: <AANLkTimhQg1LD-EVW9S45KiC9k6JXpSw_OBdUw=JyFYE@mail.gmail.com> (raw)
In-Reply-To: <jwviq2rezog.fsf-monnier+emacs@gnu.org>

Hi, I worked with Daniel on this patch. I'm a frequent Octave user and
so far casual contributor.

On 31 August 2010 07:32, Stefan Monnier <monnier@iro.umontreal.ca>
wrote:
> I'm not familiar with Octave, so your code might be more correct in
> some cases, OTOH my code handles multi-line strings. Do you think we
> should try and get the best of both worlds, or should we replace my
> code with yours, or should we just stick with my code?

Daniel's code is correct in several cases I tried, so I would
recommend it. I don't know what you may have done with multiline
strings, but they seem to work just as well. Of course it would be
nice if both features worked.

Octave mode still requires a lot of work in other directions. Octave
syntax has been enriched somewhat since the mode was first written.
With time I may be able to provide these necessary patches myself.

- Jordi G. H.



  reply	other threads:[~2010-08-31 21:15 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-30 21:19 [PATCH] let octave-mode understand single-quoted strings Daniel Colascione
2010-08-31 12:32 ` Stefan Monnier
2010-08-31 21:15   ` Jordi Gutiérrez Hermoso [this message]
2010-09-01  6:46     ` Stefan Monnier
2010-09-02 14:07       ` Jordi Gutiérrez Hermoso
2010-09-02 16:24         ` Stefan Monnier
2010-09-02 23:46           ` Jordi Gutiérrez Hermoso
2010-09-03 10:48             ` Stefan Monnier
2010-10-05  8:28               ` John W. Eaton
2010-10-05 23:57                 ` Eric M. Ludlam
2010-10-07  8:41                   ` Stefan Monnier
2011-10-04 15:13                     ` Jordi Gutiérrez Hermoso
2011-10-04 17:40                       ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimhQg1LD-EVW9S45KiC9k6JXpSw_OBdUw=JyFYE@mail.gmail.com' \
    --to=jordigh@gmail.com \
    --cc=daniel@censorshipresearch.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.