From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6147: 23.2; ido-read-buffer regression Date: Mon, 10 May 2010 01:02:30 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1273447596 6722 80.91.229.12 (9 May 2010 23:26:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 9 May 2010 23:26:36 +0000 (UTC) Cc: 6147@debbugs.gnu.org To: Kyle Hargraves Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 10 01:26:34 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBFtH-00028o-Jx for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 May 2010 01:26:31 +0200 Original-Received: from localhost ([127.0.0.1]:45169 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBFtG-0000uG-SA for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 May 2010 19:26:30 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OBFtC-0000uB-SF for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:26:26 -0400 Original-Received: from [140.186.70.92] (port=50355 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBFt9-0000u2-St for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:26:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBFt7-0007yL-Rk for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:26:23 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55768) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBFt7-0007yD-OW for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:26:21 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OBFWY-0007DG-5L; Sun, 09 May 2010 19:03:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 May 2010 23:03:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6147 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6147-submit@debbugs.gnu.org id=B6147.127344617627720 (code B ref 6147); Sun, 09 May 2010 23:03:02 +0000 Original-Received: (at 6147) by debbugs.gnu.org; 9 May 2010 23:02:56 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBFWS-0007D3-1x for submit@debbugs.gnu.org; Sun, 09 May 2010 19:02:56 -0400 Original-Received: from mail-bw0-f214.google.com ([209.85.218.214]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBFWQ-0007Cy-OA for 6147@debbugs.gnu.org; Sun, 09 May 2010 19:02:55 -0400 Original-Received: by bwz6 with SMTP id 6so1416130bwz.39 for <6147@debbugs.gnu.org>; Sun, 09 May 2010 16:02:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=eRkN/5JO8F0iY/zSZoJN4BbkF+tsJ1WNWb09HftE6OU=; b=YFpDPHOFiZf3x+XZbGxXp5wFsj6aj/8/MlmSXqLTwg9tbt98WGUDqTOtPHSActEnY/ iPcC6QTzj9ONQpFZZ6fptc6WU+AM9+pUBbdpK25sS/mCZDV8HZysDLt141g7XQXHElTZ ZCKJ6dAFSJqWIb/jaqQN7szjsNTZ6qPJgD53M= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=PO7Ccce1f8dcPzuOlbZ6wG6o1HmdRgeftH3WEgkez6BnRoyw6N4Ib42F84SdBg74ot Y9WN73vTFSPzd1gcNXOaD5O6aShcNn3uzFlzWZkMcE5EXvlwcy3IkZlGjswfeFPu4YkO 0b6Tvx0IKmoFoLsgJgr266yfRJ2FS38ryqrK8= Original-Received: by 10.204.6.73 with SMTP id 9mr1882334bky.143.1273446170149; Sun, 09 May 2010 16:02:50 -0700 (PDT) Original-Received: by 10.204.84.81 with HTTP; Sun, 9 May 2010 16:02:30 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 09 May 2010 19:03:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36810 Archived-At: On Sun, May 9, 2010 at 22:06, Kyle Hargraves wrote: > This can be reproduced by evaluating: > (ido-read-buffer "Buffer: " "nonexistent-buffer") > In 23.2, you will see only a list of your current buffers. In 23.1, > nonexistent-buffer is the default value. Yes, it has changed. > I believe the related commit may be: > http://github.com/emacsmirror/emacs/commit/e2300713fd5a941bfe1dad338b88f4= caf77cc945 Why do you believe that? AFAICS, that commit is related to virtual buffers, and so it's not on Emacs 23.2. The "culprit" is this change: ------------------------------------------------------------ revno: 99373 author: =C3=93scar Fuentes committer: Juanma Barranquero branch nick: trunk timestamp: Mon 2010-01-18 20:34:55 +0100 message: ido.el: Consider the possibility of buffer names changing after kill-bu= ffer. which includes this: (ido-make-buffer-list): If "default" is a nonexistent buffer, ignore it, as per the docstring. =3D=3D=3D modified file 'lisp/ido.el' --- lisp/ido.el 2010-01-13 08:35:10 +0000 +++ lisp/ido.el 2010-01-18 19:34:55 +0000 @@ -3344,7 +3344,7 @@ (if ido-temp-list (nconc ido-temp-list ido-current-buffers) (setq ido-temp-list ido-current-buffers)) - (if default + (if (and default (buffer-live-p (get-buffer default))) (progn (setq ido-temp-list (delete default ido-temp-list)) Now, though `ido-make-buffer-list' has not exactly a docstring, but a comment, it really says: ;; [...] If DEFAULT is non-nil, and corresponds to an existing buffer, ;; it is put to the start of the list. so the use you did of it was relying on undocumented behaviour. Whether it should work as you prefer or not, I have no comment; but there has been some recent discussion on emacs-devel about reverting this patch and replacing it with another fix, by Leo (see thread titled "PATCH: Fix IDO interaction with uniquify.el"); so perhaps you can chime in with your thoughts. Juanma