From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Key Newsgroups: gmane.emacs.devel Subject: Re: C-h v problem on Emacs trunk on Mac OS X Date: Mon, 21 Feb 2011 04:08:16 -0600 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0016e6de04210811de049cc80c54 X-Trace: dough.gmane.org 1298283103 5339 80.91.229.12 (21 Feb 2011 10:11:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 21 Feb 2011 10:11:43 +0000 (UTC) To: Emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Feb 21 11:11:39 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PrSjy-0007U4-Dw for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 11:11:38 +0100 Original-Received: from localhost ([127.0.0.1]:57180 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrShF-0005BV-Dv for ged-emacs-devel@m.gmane.org; Mon, 21 Feb 2011 05:08:49 -0500 Original-Received: from [140.186.70.92] (port=38697 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PrSh5-0005A7-2t for Emacs-devel@gnu.org; Mon, 21 Feb 2011 05:08:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PrSh4-0001PH-1U for Emacs-devel@gnu.org; Mon, 21 Feb 2011 05:08:38 -0500 Original-Received: from mail-bw0-f52.google.com ([209.85.214.52]:38795) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PrSh3-0001Ot-T6 for Emacs-devel@gnu.org; Mon, 21 Feb 2011 05:08:38 -0500 Original-Received: by bwz4 with SMTP id 4so5537066bwz.39 for ; Mon, 21 Feb 2011 02:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:content-type; bh=IfO7lW0zPfvdbteXetMoKGWVoYgRguLa50FzaG28bZU=; b=dCdZp6142d3K7CXxC5gNCiu9O0X/5EEBap1JVlMtoWymgw3tbiE3WDnJF7YanODyo2 1NW5GntYYndfgWqLsPsoDTBiNaPqbZdo+CbeFLpGfIs8dMmYmNKwRcxk1PuqA1HE9DT0 S/wPUXa6zxTio6w5UQCoFGI9MENMkGpwoDrE4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; b=uQrTtRCoiJcQIj96MFF0t7Y9UW+53vczse65j00lFyvVRTb/+kPOkXNWjNPlQB7V40 qntA4jwCuCx3+C8g8t7GcMyg1Ip3TVbamDR5wHSmOUF377/9YPUug2j+gnupX7CoahmU lZov14FF1RjScyKFktHok51kDwekRV39EmKRg= Original-Received: by 10.204.71.20 with SMTP id f20mr1126243bkj.139.1298282916089; Mon, 21 Feb 2011 02:08:36 -0800 (PST) Original-Received: by 10.204.25.81 with HTTP; Mon, 21 Feb 2011 02:08:16 -0800 (PST) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.214.52 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136320 Archived-At: --0016e6de04210811de049cc80c54 Content-Type: text/plain; charset=ISO-8859-1 Hello, I have some more information on the cause of this bug. It turns out that it is an unintended consequence of the recent BVAR and KVAR changes. The parser used be make-docfile is very simplistic. It assumes that when it sees a DEFVAR_PER_BUFFER it can start looking for the documentation after 2 commas. This assumption is no longer valid because of the added comma in the usage of the BVAR macro. The following patch appears to fix this problem. === modified file 'lib-src/make-docfile.c' --- lib-src/make-docfile.c 2011-02-09 00:30:33 +0000 +++ lib-src/make-docfile.c 2011-02-21 09:39:03 +0000 @@ -815,7 +815,7 @@ if (defunflag) commas = 5; else if (defvarperbufferflag) - commas = 2; + commas = 3; else if (defvarflag) commas = 1; else /* For DEFSIMPLE and DEFPRED */ --0016e6de04210811de049cc80c54 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hello,

I have some more information on the cause of= this bug.=A0 It turns out that it is an unintended consequence of the rece= nt BVAR and KVAR changes.=A0 The parser used be make-docfile is very simpli= stic.=A0 It assumes that when it sees a DEFVAR_PER_BUFFER it can start look= ing for the documentation after 2 commas.=A0 This assumption is no longer v= alid because of the added comma in the usage of the BVAR macro.

The following patch appears to fix this problem.

<patch>=3D=3D=3D modified file 'lib-src/make-docfile.c'
--- lib-src/m= ake-docfile.c=A0=A0=A0 2011-02-09 00:30:33 +0000
+++ lib-src/make-docfil= e.c=A0=A0=A0 2011-02-21 09:39:03 +0000
@@ -815,7 +815,7 @@
=A0=A0=A0=A0=A0=A0 if (defunflag)
=A0=A0=A0=A0 co= mmas =3D 5;
=A0=A0=A0=A0=A0=A0 else if (defvarperbufferflag)
-=A0=A0= =A0 commas =3D 2;
+=A0=A0=A0 commas =3D 3;
=A0=A0=A0=A0=A0=A0 else if= (defvarflag)
=A0=A0=A0=A0 commas =3D 1;
=A0=A0=A0=A0=A0=A0 else=A0 /= * For DEFSIMPLE and DEFPRED */

</patch>

 --0016e6de04210811de049cc80c54--