all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ben Key <bkey76@gmail.com>
To: Emacs-devel@gnu.org
Subject: Re: C-h v problem on Emacs trunk on Mac OS X
Date: Mon, 21 Feb 2011 04:08:16 -0600	[thread overview]
Message-ID: <AANLkTimV463+a=VcccWpQ+H2TD7SxebrHM-jB+W5kq_O@mail.gmail.com> (raw)
In-Reply-To: <AANLkTinFXKtBL9HtYRWk-5YfHqvm+24viYWMwKyB6ixT@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 852 bytes --]

Hello,

I have some more information on the cause of this bug.  It turns out that it
is an unintended consequence of the recent BVAR and KVAR changes.  The
parser used be make-docfile is very simplistic.  It assumes that when it
sees a DEFVAR_PER_BUFFER it can start looking for the documentation after 2
commas.  This assumption is no longer valid because of the added comma in
the usage of the BVAR macro.

The following patch appears to fix this problem.

<patch>
=== modified file 'lib-src/make-docfile.c'
--- lib-src/make-docfile.c    2011-02-09 00:30:33 +0000
+++ lib-src/make-docfile.c    2011-02-21 09:39:03 +0000
@@ -815,7 +815,7 @@
       if (defunflag)
     commas = 5;
       else if (defvarperbufferflag)
-    commas = 2;
+    commas = 3;
       else if (defvarflag)
     commas = 1;
       else  /* For DEFSIMPLE and DEFPRED */

</patch>

[-- Attachment #2: Type: text/html, Size: 975 bytes --]

  reply	other threads:[~2011-02-21 10:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-20  4:12 C-h v problem on Emacs trunk on Mac OS X Ben Key
2011-02-20  7:48 ` Ben Key
2011-02-21 10:08   ` Ben Key [this message]
2011-02-21 18:03     ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTimV463+a=VcccWpQ+H2TD7SxebrHM-jB+W5kq_O@mail.gmail.com' \
    --to=bkey76@gmail.com \
    --cc=Emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.