From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Why on earth is abbrev baked into the C code? Date: Tue, 1 Mar 2011 13:08:55 -0800 Message-ID: References: <4D69BFD2.7060606@gmail.com> <4D6BF0D7.3080005@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 X-Trace: dough.gmane.org 1299013752 1599 80.91.229.12 (1 Mar 2011 21:09:12 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 1 Mar 2011 21:09:12 +0000 (UTC) Cc: Emacs development discussions To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Mar 01 22:09:07 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PuWod-0001Vh-Jh for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2011 22:09:07 +0100 Original-Received: from localhost ([127.0.0.1]:55279 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuWoc-0004Py-Pv for ged-emacs-devel@m.gmane.org; Tue, 01 Mar 2011 16:09:06 -0500 Original-Received: from [140.186.70.92] (port=49607 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PuWoU-0004Oo-IC for emacs-devel@gnu.org; Tue, 01 Mar 2011 16:08:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PuWoT-0001Yl-Cp for emacs-devel@gnu.org; Tue, 01 Mar 2011 16:08:58 -0500 Original-Received: from mail-vx0-f169.google.com ([209.85.220.169]:47539) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PuWoT-0001Yd-9E for emacs-devel@gnu.org; Tue, 01 Mar 2011 16:08:57 -0500 Original-Received: by vxc38 with SMTP id 38so5745044vxc.0 for ; Tue, 01 Mar 2011 13:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=/O+SqcW9eXZYcLnSb2ZpU9KtZLYrOMH4hDzJIhn8Dgc=; b=xIaPtSkluiHRyVxpXyfFhgIfFlPh8JMPVIchHbvNEhF8hVBXkVTSVy08+jqCz5ofSd VjCHzACqd4VUsNkiGHOb5jFG7t4UrU+EjG1wikTLUyCY65DLlRXfJMQvTXKa91hlRHSK zrp26aPbKMvdxMyuUW7vVbONM0aoIcPqAVMVg= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=h/9KCDaPrysHvi7nbs6j2KMcX5G+jCvCtzMDCB7vjraxOc+LzEpU5XVMwvZB7BCq5u hTFlF6vitEJ6AAlKXR2uKWWTWX+Y3LD+PQiUIwLA6M9TXeoazjnJcyV9jqY/By5zXne3 w2vjHpxwzBI1Ednn0damChuJgUbPulmnxHb4Q= Original-Received: by 10.52.18.36 with SMTP id t4mr1929970vdd.285.1299013735992; Tue, 01 Mar 2011 13:08:55 -0800 (PST) Original-Received: by 10.220.74.205 with HTTP; Tue, 1 Mar 2011 13:08:55 -0800 (PST) In-Reply-To: <4D6BF0D7.3080005@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.220.169 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:136690 Archived-At: ;; This hack works for me, but there must be an easier, safer way. (defun qtmstr-expand-abbrev-wrapper (orig-func &rest args) (if (and qtmstr-abbrev-mode (eq this-command 'self-insert-command) (not executing-kbd-macro) (not noninteractive) (not (window-minibuffer-p (selected-window))) (characterp last-command-event)) ;; Our own implementation of expand-abbrev (destructuring-bind (&optional sym name wordstart wordend) (abbrev--before-point) (when sym (let ((value sym)) ;; Now sym is the abbrev symbol. (setq last-abbrev-text name) (setq last-abbrev sym) (setq last-abbrev-location wordstart) ;; Do what the self-insert-command would normally do (insert-char last-command-event 1 t) (undo-boundary) (delete-char -1) ;; If this abbrev has an expansion, delete the abbrev ;; and insert the expansion. (abbrev-insert sym name wordstart wordend)))) ;; Otherwise, let the original expand-abbrev do its thing (apply orig-func args))) (add-hook 'abbrev-expand-functions #'qtmstr-expand-abbrev-wrapper)