From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Olson Newsgroups: gmane.emacs.erc.general,gmane.emacs.devel Subject: Re: Patch to fix ERC mode's IRC protocol logging Date: Wed, 4 Aug 2010 10:27:32 -0700 Message-ID: References: Reply-To: ERC Discussion NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280943101 25929 80.91.229.12 (4 Aug 2010 17:31:41 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 Aug 2010 17:31:41 +0000 (UTC) Cc: ERC Discussion , Francis Litterio , emacs-devel@gnu.org To: Deniz Dogan Original-X-From: erc-discuss-bounces+sf-erc-help=m.gmane.org@gnu.org Wed Aug 04 19:31:38 2010 Return-path: Envelope-to: sf-erc-help@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OghoX-000053-L6 for sf-erc-help@m.gmane.org; Wed, 04 Aug 2010 19:31:37 +0200 Original-Received: from localhost ([127.0.0.1]:43221 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OghoU-0008Lv-Ax for sf-erc-help@m.gmane.org; Wed, 04 Aug 2010 13:31:34 -0400 Original-Received: from [140.186.70.92] (port=37887 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Oghl0-0005AQ-RZ for erc-discuss@gnu.org; Wed, 04 Aug 2010 13:27:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Oghkz-000344-TT for erc-discuss@gnu.org; Wed, 04 Aug 2010 13:27:58 -0400 Original-Received: from mail-wy0-f169.google.com ([74.125.82.169]:35228) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Oghkx-00033B-ID; Wed, 04 Aug 2010 13:27:55 -0400 Original-Received: by wyg36 with SMTP id 36so6366781wyg.0 for ; Wed, 04 Aug 2010 10:27:54 -0700 (PDT) Original-Received: by 10.216.210.206 with SMTP id u56mr7959079weo.50.1280942873454; Wed, 04 Aug 2010 10:27:53 -0700 (PDT) Original-Received: by 10.216.80.136 with HTTP; Wed, 4 Aug 2010 10:27:32 -0700 (PDT) X-Originating-IP: [216.103.134.130] In-Reply-To: X-Google-Sender-Auth: _rWh2MlR0G2YBBHLHAi6Xdq8YUc X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: erc-discuss@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ERC Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: erc-discuss-bounces+sf-erc-help=m.gmane.org@gnu.org Errors-To: erc-discuss-bounces+sf-erc-help=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.erc.general:1300 gmane.emacs.devel:128256 Archived-At: The patch looks good to me. I'd say check it into Emacs (if you haven't already done so) and send a courtesy copy to erc-discuss for future patches. The version of ERC in Emacs is probably going to be the most canonical going forward, since it's the easiest to commit changes to. On Mon, Jul 19, 2010 at 8:22 PM, Deniz Dogan wr= ote: > 2010/7/20 Francis Litterio : >> Deniz Dogan wrote: >> >>> 2010/7/19 Fran Litterio: >>> > The below patch fixes a problem in ERC where erc-toggle-debug-irc-pro= tocol >>> > was not logging inbound protocol data. It also changes the key to int= eractively >>> > toggle protocol logging so that it doesn't interfere with View mode b= indings. >> >>> Thank you! You should probably also send it to erc-discuss gnu.org= in >>> case the ERC mantainer doesn't read emacs-devel. >> >> Do patches for ERC have to go into the upstream ERC source first in >> order to make it into Emacs? =C2=A0I thought that since ERC was now part= of >> Emacs, patches can go directly into the Emacs source. > > I guess I have the same understanding as you, but it may be more > likely that you receive more feedback on the patch from erc-discuss. > > -- > Deniz Dogan > > --=20 Michael Olson=C2=A0 |=C2=A0 http://mwolson.org/