From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6493: Date: Fri, 23 Jul 2010 11:30:47 +0200 Message-ID: References: <969BF38D66A0450F88923BFF8942AC68@us.oracle.com> <6B20ABD762564DE2AEBA810B54EB46FD@us.oracle.com> <21D2CFB9CFF34D04906728113DA42430@us.oracle.com> <6C93D3874C204C6BACB34962781ED1C9@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279877859 16913 80.91.229.12 (23 Jul 2010 09:37:39 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 23 Jul 2010 09:37:39 +0000 (UTC) Cc: 6493@debbugs.gnu.org To: Deniz Dogan Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 23 11:37:38 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OcEhF-0005DN-Oc for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jul 2010 11:37:38 +0200 Original-Received: from localhost ([127.0.0.1]:55893 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcEhE-0002cX-Qy for geb-bug-gnu-emacs@m.gmane.org; Fri, 23 Jul 2010 05:37:36 -0400 Original-Received: from [140.186.70.92] (port=60924 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OcEh3-0002b4-O8 for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 05:37:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OcEh2-0008WB-ER for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 05:37:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57960) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcEh2-0008W2-80 for bug-gnu-emacs@gnu.org; Fri, 23 Jul 2010 05:37:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OcEbq-0001KA-Ks; Fri, 23 Jul 2010 05:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Jul 2010 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6493 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6493-submit@debbugs.gnu.org id=B6493.12798774745079 (code B ref 6493); Fri, 23 Jul 2010 09:32:02 +0000 Original-Received: (at 6493) by debbugs.gnu.org; 23 Jul 2010 09:31:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcEb2-0001Js-Tg for submit@debbugs.gnu.org; Fri, 23 Jul 2010 05:31:13 -0400 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OcEb1-0001Jn-35 for 6493@debbugs.gnu.org; Fri, 23 Jul 2010 05:31:11 -0400 Original-Received: by bwz7 with SMTP id 7so1558598bwz.3 for <6493@debbugs.gnu.org>; Fri, 23 Jul 2010 02:31:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=mqf4FAXUXdzibfYcNM4d7U/IMH8qpdENqHnV/FNiOXk=; b=NSFNWixP1dkeelVpfEPTcuO2W7ltzCO0KLA6i8Vd7FVORGhA0F4dQUFnSSimoKik6t 1r3YCpg8PxyT42h0xNCXD7/uXg014nVaL1MPLN0ujDoLCtnnIXG9/xRqRXcXoQayY/bO QpqYiKF6msw531l8RejOlvdHFkOdGgOPCbvq4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=ryyxswjNmbj+whLaGFaTsrtbK8ceErfFmp4p4FsZv446uUQ8iDBkBjAcHFxasO9DKD ylyRX5XiMGAeRMmH9Qye3baBpwPR/3ceaHIYBlo6vSJnQ4ckHsD1Hq2CKgaSbsVB/S5v gUY2BWxJY9XkckergOzMn8oUOuq8G+V91Dy5c= Original-Received: by 10.204.102.138 with SMTP id g10mr2562931bko.42.1279877467123; Fri, 23 Jul 2010 02:31:07 -0700 (PDT) Original-Received: by 10.204.180.136 with HTTP; Fri, 23 Jul 2010 02:30:47 -0700 (PDT) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Fri, 23 Jul 2010 05:32:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38809 Archived-At: On Fri, Jul 23, 2010 at 11:10, Deniz Dogan wrot= e: > Attached is a new patch. Thanks. Three comments: - You changed "Return" to "Returns", but it is standard Emacs practice to make the first line in a docstring imperative. From (elisp) D.6 "Tips for Documentation Strings": For consistency, phrase the verb in the first sentence of a function's documentation string as an imperative--for instance, use "Return the cons of A and B." in preference to "Returns the cons of A and B." - You didn't write ChangeLog entries. They are trivial in this case (so no need to resend), but usually a patch should include them. - This thead has been just Drew and you, and I'm not sure the result is better. Though I understand Drew's arguments, it is still a bit weird to me to look at the docstring of region-(beginning|end) and not to see *any* reference to the region (yes, I know it is implicit in "point or mark"). So I'd like to hear more opinions. =C2=A0 =C2=A0 Juanma =3D=3D=3D modified file 'src/editfns.c' --- src/editfns.c 2010-06-16 20:08:41 +0000 +++ src/editfns.c 2010-06-27 12:22:00 +0000 @@ -349,14 +349,18 @@ } DEFUN ("region-beginning", Fregion_beginning, Sregion_beginning, 0, 0, 0, - doc: /* Return position of beginning of region, as an integer. */) + doc: /* Returns the smaller of point or mark, as a nonnegative inte= ger. + +Raises an error if the mark is not set. */) () { return region_limit (1); } DEFUN ("region-end", Fregion_end, Sregion_end, 0, 0, 0, - doc: /* Return position of end of region, as an integer. */) + doc: /* Returns the larger of point or mark, as a nonnegative integ= er. + +Raises an error if the mark is not set. */) () { return region_limit (0);