From: Juanma Barranquero <lekktu@gmail.com>
To: Christoph <cschol2112@googlemail.com>
Cc: 6602-done@debbugs.gnu.org
Subject: bug#6602: [PATCH] make dist target for Windows
Date: Sat, 24 Jul 2010 15:28:41 +0200 [thread overview]
Message-ID: <AANLkTimEDDykKMM2Gj3dNYd=kAvpQu9sF4BWVG-FwKkn@mail.gmail.com> (raw)
In-Reply-To: <4C4A5B6A.9080700@gmail.com>
On Sat, Jul 24, 2010 at 05:18, Christoph <cschol2112@googlemail.com> wrote:
> Find attached the new patch for the `make dist' target.
>
> I added a Changelog and NEWS entry and removed README.W32 and makedist.bat
> files from the nt/ directory.
OK, thaks a lot.
A few comments (nitpicks, mostly):
- You've added the ChangeLog entry to the root directory's ChangeLog,
instead of nt/ChangeLog. Also, it lacks an entry in admin/ChangeLog
about the changes in that directory (you've documented most of them in
the other ChangeLog, though). In some cases, as when moving files, it
is customary to put a "Moved to X/" entry in the old directory's
ChangeLog, and ad "Moved from Y/" in the new's.
- Changes to documentation files, like etc/NEWS and nt/INSTALL, must
also be documented in ChangeLog entries.
- If you're going to move a file, like README.W32, instead of
cd admin/nt
copy README.W32 ../../nt
del README.W32
or
move admin/nt/README.W32 nt/
please do
bzr mv admin/nt/README.W32 nt/
so Bazaar knows that it is the same file.
- It's best if you do these changes in a branch, and then submit a
bundle. For example, applying your patch creates a file
nt/zipdist.bat, but it has to be "bzr add"ed manually.
- Try not to introduce trailing whitespace in files you modify. Not
earth-shaking, but ugly if you have `show-trailing-whitespace' set to
t (which I recommend).
That said, I'm committing your change right now. Great work. Thanks!
Juanma
next prev parent reply other threads:[~2010-07-24 13:28 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-10 14:00 bug#6602: [PATCH] make dist target for Windows Christoph
2010-07-22 9:19 ` Juanma Barranquero
2010-07-22 9:20 ` Juanma Barranquero
2010-07-22 10:01 ` Juanma Barranquero
2010-07-23 1:14 ` Christoph
2010-07-23 1:22 ` Juanma Barranquero
2010-07-24 3:18 ` Christoph
2010-07-24 13:28 ` Juanma Barranquero [this message]
2010-07-24 13:31 ` Juanma Barranquero
2010-07-24 22:19 ` Christoph
2010-07-25 1:01 ` Juanma Barranquero
2010-07-25 2:04 ` Christoph
2010-07-25 2:55 ` Juanma Barranquero
2010-07-25 3:18 ` Christoph
2010-07-25 3:58 ` Juanma Barranquero
2010-07-25 4:44 ` Christoph
2010-07-25 12:30 ` Sean Sieger
2010-07-25 14:09 ` Christoph
2010-07-25 17:36 ` Sean Sieger
2010-07-27 22:25 ` Sean Sieger
2010-07-27 23:04 ` Juanma Barranquero
2010-07-27 23:32 ` Christoph
2010-07-28 1:31 ` Sean Sieger
2010-07-27 23:25 ` Christoph
2010-07-28 1:33 ` Sean Sieger
2010-07-27 1:48 ` Christoph
2010-07-27 21:08 ` Sean Sieger
2010-07-27 22:59 ` Juanma Barranquero
2010-07-28 1:34 ` Sean Sieger
2010-07-27 23:08 ` Christoph
2010-07-28 1:38 ` Sean Sieger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTimEDDykKMM2Gj3dNYd=kAvpQu9sF4BWVG-FwKkn@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=6602-done@debbugs.gnu.org \
--cc=cschol2112@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.