bug#6155: Crashes on w32 because of bad frame initialization

bug#6155: Crashes on w32 because of bad frame initialization

[Lennart Borgman]

I have seen numerous crashes on w32 when a frame has been badly
initialized. I wonder if the problem is that frames can get half
initialized.

In the function Fx_create_frame a bad value coming from a frame
parameter (menu-bar-lines . t) will lead to an error in

  x_default_parameter (f, parameters, Qmenu_bar_lines, make_number (1),
		       "menuBar", "MenuBar", RES_TYPE_NUMBER);

Does not that leave the frame half initialized?

(I am loooking at the code from a trunk checkout done 2010-05-06.)

bug#6155: Crashes on w32 because of bad frame initialization

[Juanma Barranquero]

> I have seen numerous crashes on w32 when a frame has been badly
> initialized. I wonder if the problem is that frames can get half
> initialized.
>
> In the function Fx_create_frame a bad value coming from a frame
> parameter (menu-bar-lines . t) will lead to an error in
>
>  x_default_parameter (f, parameters, Qmenu_bar_lines, make_number (1),
>                       "menuBar", "MenuBar", RES_TYPE_NUMBER);
>
> Does not that leave the frame half initialized?

Do you have a recipe to reproduce the problem'

    Juanma

bug#6155: Crashes on w32 because of bad frame initialization

[Lennart Borgman]

On Mon, May 10, 2010 at 5:12 PM, Juanma Barranquero <lekktu@gmail.com> wrote:
>> I have seen numerous crashes on w32 when a frame has been badly
>> initialized. I wonder if the problem is that frames can get half
>> initialized.
>>
>> In the function Fx_create_frame a bad value coming from a frame
>> parameter (menu-bar-lines . t) will lead to an error in
>>
>>  x_default_parameter (f, parameters, Qmenu_bar_lines, make_number (1),
>>                       "menuBar", "MenuBar", RES_TYPE_NUMBER);
>>
>> Does not that leave the frame half initialized?
>
> Do you have a recipe to reproduce the problem'

I have no exact recipe but I noticed the problem when the above
parameter was in the list of parameters to make frame.

The `t' in (menu-bar-lines . t) shoudld be a number. In make-frame I
got an error and shortly afterwards Emacs crashed.

bug#6155: Crashes on w32 because of bad frame initialization

[Juanma Barranquero]

On Mon, May 10, 2010 at 18:00, Lennart Borgman
<lennart.borgman@gmail.com> wrote:

> The `t' in (menu-bar-lines . t) shoudld be a number. In make-frame I
> got an error and shortly afterwards Emacs crashed.

(progn
  (push '(menu-bar-lines . t) default-frame-alist)
  (make-frame))

does not fail for me either.

    Juanma

bug#6155: Crashes on w32 because of bad frame initialization

[Lennart Borgman]

On Mon, May 10, 2010 at 7:41 PM, Juanma Barranquero <lekktu@gmail.com> wrote:
> On Mon, May 10, 2010 at 18:00, Lennart Borgman
> <lennart.borgman@gmail.com> wrote:
>
>> The `t' in (menu-bar-lines . t) shoudld be a number. In make-frame I
>> got an error and shortly afterwards Emacs crashed.
>
> (progn
>  (push '(menu-bar-lines . t) default-frame-alist)
>  (make-frame))

This should perhaps be

  (let ((frame-alist (delete '(menu-bar-lines . 1) default-frame-alist)))
    (setq frame-alist (cons '(menu-bar-lines . t) frame-alist))
    (make-frame frame-alist))

but I do not get an error from that now either. Sigh, I thought I had
tracked down an example that worked. I wonder what is different now.

I will test a bit more.

bug#6155: Crashes on w32 because of bad frame initialization

[Juanma Barranquero]

> This should perhaps be

No, I don't think it *should*.

>  (let ((frame-alist (delete '(menu-bar-lines . 1) default-frame-alist)))

Unnecessary. `assoc' and friends will find the first matching key.

>    (setq frame-alist (cons '(menu-bar-lines . t) frame-alist))

Identical to my `push', only I was using `default-frame-alist' (on purpose).

>    (make-frame frame-alist))

Unnecessary in my example. `make-frame' already uses `default-frame-alist'.

Please try

(let ((default-frame-alist default-frame-alist))
  (push '(menu-bar-lines . 0) default-frame-alist)
  (make-frame))

to see that it works.

    Juanma

bug#6155: Crashes on w32 because of bad frame initialization

[Glenn Morris]

In the absence of a recipe to reproduce the issue or a backtrace from a
crash (from a vanilla Emacs with debugging info) I don't think anything
can be done. Please reopen or reply to this report if you get either of
those.

bug#6155: Crashes on w32 because of bad frame initialization

[Lennart Borgman]

On Tue, Jul 12, 2011 at 01:16, Glenn Morris <rgm@gnu.org> wrote:
>
> In the absence of a recipe to reproduce the issue or a backtrace from a
> crash (from a vanilla Emacs with debugging info) I don't think anything
> can be done. Please reopen or reply to this report if you get either of
> those.

I have not gone this crash any more. Perhaps it was related to one of
the other bug reports about frames. I think I fixed some system call
there, but I do not remember any more.