From: Juanma Barranquero <lekktu@gmail.com>
To: Drew Adams <drew.adams@oracle.com>
Cc: 7118@debbugs.gnu.org
Subject: bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local
Date: Tue, 28 Sep 2010 01:35:12 +0200 [thread overview]
Message-ID: <AANLkTim=NwY82rFqO+X6QVMicUcoBJPkcxW8--=TWEic@mail.gmail.com> (raw)
In-Reply-To: <B53179EFF1B54D4EA98E63D1B3DD2602@us.oracle.com>
On Mon, Sep 27, 2010 at 20:47, Drew Adams <drew.adams@oracle.com> wrote:
> We should use `make-variable-buffer-local' with vars such as
> `dired-subdir-alist' and `dired-directory', instead of just calling
> `make-local-variable'. Why? Because these vars MUST be buffer local,
> and we might as well make the code clearer by pointing that out. That
> is precisely the use case for `make-variable-buffer-local': a var that
> is necessarily buffer-local.
On the same vein, every single use of revert-buffer-function starts with
(make-local-variable 'revert-buffer-function)
(setq revert-buffer-function XXXXX)
or
(set (make-local-variable 'revert-buffer-function) XXXXXX)
except the one in dired-x.el, which relies in dired-mode doing it
before. There have been at least three bugs in the past year caused by
revert-buffer-function not being automatically buffer-local.
Juanma
next prev parent reply other threads:[~2010-09-27 23:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-09-27 18:47 bug#7118: 24.0.50; dired-subdir-alist, dired-directory, etc.: necessarily buffer-local Drew Adams
2010-09-27 21:05 ` Stefan Monnier
2011-07-14 14:21 ` Lars Magne Ingebrigtsen
2011-07-14 14:45 ` Juanma Barranquero
2011-07-14 14:49 ` Lars Magne Ingebrigtsen
2011-07-17 2:24 ` Stefan Monnier
2011-08-02 21:11 ` Drew Adams
2010-09-27 23:35 ` Juanma Barranquero [this message]
2022-02-07 0:31 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTim=NwY82rFqO+X6QVMicUcoBJPkcxW8--=TWEic@mail.gmail.com' \
--to=lekktu@gmail.com \
--cc=7118@debbugs.gnu.org \
--cc=drew.adams@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.