From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Leo Newsgroups: gmane.emacs.devel Subject: Re: Concerning the new `ido-use-virtual-buffers' feature Date: Thu, 27 May 2010 19:01:04 +0100 Message-ID: References: <201005271257.02056.tassilo@member.fsf.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1274983511 2835 80.91.229.12 (27 May 2010 18:05:11 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 27 May 2010 18:05:11 +0000 (UTC) Cc: John Wiegley , "Kim F. Storm" , emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu May 27 20:05:09 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OHhS8-0000Wa-SM for ged-emacs-devel@m.gmane.org; Thu, 27 May 2010 20:05:09 +0200 Original-Received: from localhost ([127.0.0.1]:57765 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHhS8-0004dd-78 for ged-emacs-devel@m.gmane.org; Thu, 27 May 2010 14:05:08 -0400 Original-Received: from [140.186.70.92] (port=55939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OHhOF-0000NM-88 for emacs-devel@gnu.org; Thu, 27 May 2010 14:01:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OHhOE-0002bA-0B for emacs-devel@gnu.org; Thu, 27 May 2010 14:01:07 -0400 Original-Received: from mail-ww0-f41.google.com ([74.125.82.41]:36385) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHhOD-0002an-Rs for emacs-devel@gnu.org; Thu, 27 May 2010 14:01:05 -0400 Original-Received: by wwi17 with SMTP id 17so197282wwi.0 for ; Thu, 27 May 2010 11:01:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:received:in-reply-to :references:date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=DxJKvc07q0GWHBoVxLVPNGFnLIHdEbUlGcAXE2ohDuk=; b=svTUXQ87iF/11VHAHiB1Ki+JA8Z/wgL6mQXGfe/pjSYPjMHEl1My0C7vqhMWrvf8O4 HQc/UU0yuRv/xZJVGEPVAahGeI0Z6fUdSZZWCUojfAWzSKZqBQCTt7012iYDqT9lAybz 5uuDuwIll/LYPvTPApYcvHAgWgMK4w/zLZLnM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=c5Tznua3rHAt4TsioWnVaTSeaUKNZBUqwLb0nwxMGv9BYh77HA7fOg8XcXOfK1h6HL 01XZEEMQMmmCrDEhvVATA1LOI/SnrnCyczYOp0us0rL0sZxDT18S0MpVbXCVnrFeJzkp K2VurEMKUNUV1AsWHzFGi5C1Z608VIp2iskaI= Original-Received: by 10.216.85.73 with SMTP id t51mr104704wee.3.1274983264226; Thu, 27 May 2010 11:01:04 -0700 (PDT) Original-Received: by 10.216.188.139 with HTTP; Thu, 27 May 2010 11:01:04 -0700 (PDT) In-Reply-To: <201005271257.02056.tassilo@member.fsf.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:125308 Archived-At: Hello all, On 27 May 2010 11:57, Tassilo Horn wrote: > On Thursday 27 May 2010 11:56:53 Leo wrote: > > Hi Leo, John, Kim, > >> Meanwhile feel free to change the patch. > > Hm, it doesn't apply to the current bzr trunk. =A0Anyway, I rewrote it to > be controled by the ido-use-virtual-buffers variable solely with 3 > values 'never, 'auto, and 'always. > > The resulting patch is attached. =A0Basically, it works, but there's one > bug I cannot figure out how to solve. =A0When ido-use-virtual-buffers is > 'auto and the current input doesn't even match any closed buffer > (recentf file), then it's stuck instead of displaying [no match]. > > I don't know ido very well and cannot figure out how to get that right. > Kim, maybe you could check what's wrong? I think it is in the added code in ido-exhibit which is run in post-command-hook if I remember correctly. When your input doesn't match any (including virtual ones), the code in ido-exhibit tells ido (the big LOOP in ido-read-internal) to rebuild the buffer list and there isn't any match so it rebuild again and again. Go into a infinite loop. You could try creating a new let-bound variable to detect such a situation and avoid the infinite loop. > I have papers on file. =A0I use 7 lines originating from Leo's patch, so = I > don't know if that has to wait till Leo's assignments arrive... > > Bye, > Tassilo HTH, Leo