From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.bugs Subject: bug#6663: #if 0 blocks in source code Date: Thu, 22 Jul 2010 14:31:34 +0200 Message-ID: References: <864ofxiwt9.fsf@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1279803692 17991 80.91.229.12 (22 Jul 2010 13:01:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 22 Jul 2010 13:01:32 +0000 (UTC) Cc: 6663@debbugs.gnu.org To: Christoph Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 22 15:01:31 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ObvOu-0005bl-00 for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jul 2010 15:01:30 +0200 Original-Received: from localhost ([127.0.0.1]:58664 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObvOk-0001t2-Pe for geb-bug-gnu-emacs@m.gmane.org; Thu, 22 Jul 2010 09:01:14 -0400 Original-Received: from [140.186.70.92] (port=45102 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ObvOT-0001qc-Lj for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 09:00:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1ObvOM-00077M-V3 for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 09:00:52 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53591) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1ObvOM-00077G-TX for bug-gnu-emacs@gnu.org; Thu, 22 Jul 2010 09:00:50 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1ObuwU-0008AH-G5; Thu, 22 Jul 2010 08:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Juanma Barranquero Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Jul 2010 12:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6663 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: notabug Original-Received: via spool by 6663-submit@debbugs.gnu.org id=B6663.127980189131355 (code B ref 6663); Thu, 22 Jul 2010 12:32:02 +0000 Original-Received: (at 6663) by debbugs.gnu.org; 22 Jul 2010 12:31:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obuvy-00089b-5X for submit@debbugs.gnu.org; Thu, 22 Jul 2010 08:31:30 -0400 Original-Received: from mail-bw0-f44.google.com ([209.85.214.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Obuvv-00089T-KH for 6663@debbugs.gnu.org; Thu, 22 Jul 2010 08:31:28 -0400 Original-Received: by bwz7 with SMTP id 7so891564bwz.3 for <6663@debbugs.gnu.org>; Thu, 22 Jul 2010 05:31:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=2uN65pUH8VW1Mkz+XLfGHbi1W6jMoI29vCRgS8mCtMM=; b=MlA1nRsInUWzJWyBLYWZoHDN6cSIpqe37l2dorNSVXKH6rSfZ14VWVL8qVBYPdrBlc TkC2CTJ6LJ7l2t/iLw98a/6TssRMs3Cvih4t6EUwfdwk4KgR1ohyhWaABBrUJxKVSUgM BaynjdDdw74Rem+YQJEMNv+IAC8gmNd8g3kUk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=G9MhaasP5L053BrKPVWDBCwjqF9JoHeen4gWYWfxadJ37OoGX9VHm8XSWYbWllsohd gUPOX5QAyj26lMqFheU0mPmlWh30giN1Kg+dYe+zo4k/ngNV6+5gXIaoAl4xc1yWnpSx vx6oOI99qMYV79aZdbFxFgwrQoednBQgbTNZU= Original-Received: by 10.204.128.144 with SMTP id k16mr1245709bks.171.1279801915971; Thu, 22 Jul 2010 05:31:55 -0700 (PDT) Original-Received: by 10.204.180.136 with HTTP; Thu, 22 Jul 2010 05:31:34 -0700 (PDT) In-Reply-To: <864ofxiwt9.fsf@gmail.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 22 Jul 2010 08:32:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:38760 Archived-At: On Sun, Jul 18, 2010 at 00:10, Christoph wrote: > I noticed a couple of #if 0 blocks in keyboard.c, which have explicit com= ments > that the code within the block is obsolete. A quick grep "#if 0" showed > about 200 instances of disabled or obsolete code in files in the src dire= ctory. > > Should these instances be cleaned up? Not blindly, no. Some of these code is not obsolete, it's just that it has not been made to work yet (ISTR there's such code in parts of the w32 image support, for example, but I could be wrong). Some of it is indeed obsolete, but (I think) it was felt that having it around to see would preclude people reinventing tried-and-discarded ways. That was perhaps more relevant with CVS than Bazaar (or not, because we still don't have a web interface to easily see past versions, and relying on bzr blame is clumsy). In other words, IMHO the answer is that some of these #if 0 blocks could and should be removed, but you'll have to look at them, exercise good sense and perhaps ask. Which is why most of them has never been removed, I suppose :-) Though lately, Dan and Glenn have spearheaded a big cleanup, so times, they are a-changing. =C2=A0 =C2=A0 Juanma