From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: The unwarranted scrolling assumption Date: Fri, 18 Jun 2010 16:37:55 +0200 Message-ID: References: <87ocfcj7r4.fsf@mail.jurta.org> <87631jvpzg.fsf@gmail.com> <4C18211C.3070106@harpegolden.net> <87vd9j5neu.fsf@kfs-lx.rd.rdm> <83sk4misf2.fsf@gnu.org> <83iq5hiiin.fsf@gnu.org> <83fx0lihov.fsf@gnu.org> <83aaqsiyb6.fsf@gnu.org> <83zkysh2hb.fsf@gnu.org> <83vd9gh0s6.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1276871909 17727 80.91.229.12 (18 Jun 2010 14:38:29 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 18 Jun 2010 14:38:29 +0000 (UTC) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jun 18 16:38:27 2010 connect(): No such file or directory Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OPciB-0001GU-9D for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 16:38:27 +0200 Original-Received: from localhost ([127.0.0.1]:51912 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPciA-0000pS-6w for ged-emacs-devel@m.gmane.org; Fri, 18 Jun 2010 10:38:26 -0400 Original-Received: from [140.186.70.92] (port=37297 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OPci2-0000jJ-Bc for emacs-devel@gnu.org; Fri, 18 Jun 2010 10:38:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OPci1-000392-9l for emacs-devel@gnu.org; Fri, 18 Jun 2010 10:38:18 -0400 Original-Received: from mail-yw0-f192.google.com ([209.85.211.192]:63379) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OPci1-00038p-5A; Fri, 18 Jun 2010 10:38:17 -0400 Original-Received: by ywh30 with SMTP id 30so1003950ywh.24 for ; Fri, 18 Jun 2010 07:38:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=s9wpkR5CG6uW8YHdbWBXnEEo53Sh3BQi8IqMf7oXDWQ=; b=vP8BIMuKtF0Ligw6x9Za1R9BSRkT/yqS5kdCmUZ2DmceIytOucmYZUMecAMAj+B+gZ VWgHoV4C+opueYBwrYNcObwszQycLNaS9+xYvwRVNFmlTP/vK3PPEBehfTxn61teW+9u 4mhyPF+TN/9WNNblridj9NTjzEygW4nuvfBd8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=IW6auo4yNQUeuuoRGOXq+48I9R41ND2hLutSoabwMqjsWszQnKPvvqFSk5RDfcF4em SoEY3qqpBHZv/A3GDY2wHELtuw0aFa8F1KRHdWZdilWYxqTI7pxLjS+8pdvoaC0RtztJ WPKMdIOIzffw4PayIg7Cp+ho46w5/S6ez+Wc4= Original-Received: by 10.100.245.27 with SMTP id s27mr942392anh.53.1276871895377; Fri, 18 Jun 2010 07:38:15 -0700 (PDT) Original-Received: by 10.100.154.15 with HTTP; Fri, 18 Jun 2010 07:37:55 -0700 (PDT) In-Reply-To: <83vd9gh0s6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126167 Archived-At: On Fri, Jun 18, 2010 at 4:29 PM, Eli Zaretskii wrote: >> >> This is the what I used to get the output I sent: >> >> =C2=A0 if (b->clip_changed) >> =C2=A0 =C2=A0 DebPrint (("+++reconsider: end_valid=3D%d, b=3D%d, ZV=3D%d= , BEGV=3D%d", >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0!NILP (w->window_= end_valid), >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0w->current_matrix= ->buffer =3D=3D b, >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0w->current_matrix= ->zv =3D=3D BUF_ZV (b), >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0w->current_matrix= ->begv =3D=3D BUF_BEGV (b))); > > And what was the output? =C2=A0I don't see it in this thread. Sorry, I do not have it currently. If necessary I will recreate it, but not until you have convinced me that my patch is wrong. >> The problem is how clip_changed is handled by narrow_to_region etc. >> That is what my patch is about. > > I think your patch is wrong. Yes I know. But let us look into this. So far you have not convinced me. Please try to. > I think the current code handles the > case you are trying to "fix" just fine. It looks like you are totally missing the point of my patch. > It tried to recenter for some > reason, and I'm trying to find out what that reason was. =C2=A0I'm guessi= ng > that the reason was the window_end_valid flag was nil. =C2=A0If you confi= rm > that, we could then start looking for why that flag was nil. =C2=A0Reusin= g > the current matrix when that flag is nil is unsafe. Sure I will later if it is necessary. But this is not where we are now. >> As I have said several times I think the problem is that clip_changed >> is set by narrow_to_region etc. Please look into this first. > > I already did, and I think that code is correct. =C2=A0Obviously, > clip_changed needs to be set whenever the narrowing changes. Ah, finally. Good. And why do you think that?