From: Damyan Pepper <damyanp@gmail.com>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 6303@debbugs.gnu.org
Subject: bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts)
Date: Tue, 29 Jun 2010 10:28:37 +0100 [thread overview]
Message-ID: <AANLkTildaL-eAMHQ0DgTunE79UAkDUraUPAk0D3dbQG8@mail.gmail.com> (raw)
In-Reply-To: <AANLkTim8DmqxfhRLWaphqENePlJTqUNO-fsyHx44OEUF@mail.gmail.com>
On Tue, Jun 29, 2010 at 10:03 AM, Juanma Barranquero <lekktu@gmail.com> wrote:
Thanks for having a look at this.
> Also, your contribution is long enought that it would likely require
> for you to sign papers. Have you done so?
I haven't.
> Another thing. This bit:
>
> char *str = SYMBOLP (val) ? SDATA (SYMBOL_NAME (val)) : NULL;
> if (INTEGERP (val)) str = XINT (val) != 0 ? "true" : "false";
> if (str == NULL) str = "true";
>
> would perhaps be clearer as
>
> char *str;
>
> if (INTEGERP (val))
> str = XINT (val) ? "true" : "false";
> else if (SYMBOLP (val))
> str = SDATA (SYMBOL_NAME (val));
> else
> str = "true";
>
> don't you agree?
I do.
I arranged for the code to be very similar to the code in ftfont.c -
it's pretty much a copy with some renamings and a different list of
properties. The idea was that it should be easy to refactor this so
that the two versions share the same code but pass in different arrays
of property names. Unfortunately I don't have access to a machine to
test any changes to ftfont.c on and so wasn't confident to make it
blind and without some guidance from someone more experience with the
code base.
I'm happy to try and do the refactor myself - perhaps moving the
generic version of w32font_filter_properties/ftfont_filter_properties
into font.h/font.c? At that point I'd be happier about doing a pass
through to clear up any logic in there.
next prev parent reply other threads:[~2010-06-29 9:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 8:37 bug#6303: 23.2; Win32 Antialiased fonts Damyan Pepper
[not found] ` <handler.6303.B.12751485655057.ack@debbugs.gnu.org>
2010-06-03 11:33 ` bug#6303: Acknowledgement (23.2; Win32 Antialiased fonts) Damyan Pepper
2010-06-03 11:56 ` Damyan Pepper
2010-06-29 8:24 ` Damyan Pepper
2010-06-29 9:03 ` Juanma Barranquero
2010-06-29 9:05 ` Juanma Barranquero
2010-06-29 9:28 ` Damyan Pepper [this message]
2010-06-29 9:38 ` Juanma Barranquero
2010-06-29 10:07 ` Damyan Pepper
2010-06-29 20:10 ` bug#6303: Acknowledgement (23.2; Lose32 " Richard Stallman
2010-08-20 21:58 ` bug#6303: Acknowledgement (23.2; Win32 " Stefan Monnier
2010-08-20 22:00 ` Juanma Barranquero
2010-06-29 9:24 ` Juanma Barranquero
2010-07-01 16:07 ` bug#6303: W32 Antialiased fonts Damyan Pepper
2010-07-02 8:59 ` Juanma Barranquero
2010-07-02 17:15 ` Glenn Morris
2010-07-02 17:29 ` Juanma Barranquero
2010-08-12 13:59 ` Damyan Pepper
2010-08-12 18:33 ` Juanma Barranquero
2010-10-13 14:08 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTildaL-eAMHQ0DgTunE79UAkDUraUPAk0D3dbQG8@mail.gmail.com \
--to=damyanp@gmail.com \
--cc=6303@debbugs.gnu.org \
--cc=lekktu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.