From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6227: Color isearch regexp submatches differently Date: Sun, 23 May 2010 18:40:58 +0200 Message-ID: References: <87bpca15ja.fsf@mail.jurta.org> <87wruv1ohr.fsf@mail.jurta.org> <877hmvtn9t.fsf@mail.jurta.org> <874ohyppfs.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1274633851 4153 80.91.229.12 (23 May 2010 16:57:31 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 23 May 2010 16:57:31 +0000 (UTC) Cc: 6227@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 23 18:57:30 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OGEUR-0002Tj-1a for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 May 2010 18:57:29 +0200 Original-Received: from localhost ([127.0.0.1]:52749 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGEUM-0003gw-V1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 23 May 2010 12:57:22 -0400 Original-Received: from [140.186.70.92] (port=35414 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGEUF-0003Yy-KH for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:57:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGEUA-000220-RH for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:57:12 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:59407) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGEUA-00021t-Nk for bug-gnu-emacs@gnu.org; Sun, 23 May 2010 12:57:10 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGEFV-0000Su-Ll; Sun, 23 May 2010 12:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 May 2010 16:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6227 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6227-submit@debbugs.gnu.org id=B6227.12746328841773 (code B ref 6227); Sun, 23 May 2010 16:42:01 +0000 Original-Received: (at 6227) by debbugs.gnu.org; 23 May 2010 16:41:24 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGEEu-0000SY-EU for submit@debbugs.gnu.org; Sun, 23 May 2010 12:41:24 -0400 Original-Received: from mail-yw0-f203.google.com ([209.85.211.203]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGEEt-0000ST-9r for 6227@debbugs.gnu.org; Sun, 23 May 2010 12:41:23 -0400 Original-Received: by ywh41 with SMTP id 41so1297651ywh.9 for <6227@debbugs.gnu.org>; Sun, 23 May 2010 09:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=1jn72dB8JEfcqWZReJYeDwJ6X7Ic1R83IL5J07PE8wQ=; b=e+SN1MFmr26FSFcKl681VOljJeyxwVDKcnekiP8eotDNrCVNAww91zghFGDkRLV0zV pwRejispOmvFpmxZOHLIpFajD8bttwxkqVbOIHvm8VurRa9bbfc8h0hMgmPqG0JStU6G oKsoWDfc63WMcmj7jKg3zSWR6RuYATs6Bkmp8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=NnEYklBF9T1MnL3XTNNaV99XQ/3e2WXx4R69Fq8n5vqXWRgkwpW+s3jF1WbIT654L4 E91IdjQBG42YQKoXffAIt6zBUzCSIPg8ewMlYDwGhc0R6TgTjHwIDAuzKc2f0v88O70c vgcHiDCjt+67TYyJ5dHtKbJJgbFOrfW4EZwdU= Original-Received: by 10.100.246.26 with SMTP id t26mr5313097anh.112.1274632878268; Sun, 23 May 2010 09:41:18 -0700 (PDT) Original-Received: by 10.100.177.20 with HTTP; Sun, 23 May 2010 09:40:58 -0700 (PDT) In-Reply-To: <874ohyppfs.fsf@mail.jurta.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 23 May 2010 12:42:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37210 Archived-At: On Sun, May 23, 2010 at 6:12 PM, Juri Linkov wrote: >>> I think `reb-update-overlays' should be completely rewritten >>> for isearch.el. >> >> You surely know this things much better than me, but is there any >> reason to double the code? > > `reb-update-overlays' highlights all matches in the buffer. > This is like what lazy-highlighting does. =C2=A0But we agreed > that it should affect only the current isearch match, > not all lazy-highlighted matches. > >> If it is rewritten why not let re-builder share the same code? > > Yes, and query-replace highlighting could share it too. I see. A misunderstanding, we mean the same. I wrote the reb-update-overlays should be split and I meant then into one function that hilights only one match (which is given as a parameter) and one that loops for reb-update-overlays. >>> The only thing we need from re-builder.el are faces >>> reb-match-1, reb-match-2, reb-match-3. =C2=A0We should try >>> using the existing faces for the same functionality. > > -- > Juri Linkov > http://www.jurta.org/emacs/ >