all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Lennart Borgman <lennart.borgman@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 6871@debbugs.gnu.org
Subject: bug#6871: Please make linum-mode per buffer, not per major mode
Date: Tue, 17 Aug 2010 14:35:19 +0200	[thread overview]
Message-ID: <AANLkTikzLEzfpSR883FMtxxvZW=h4vbTRLNfGtWG6e1E@mail.gmail.com> (raw)
In-Reply-To: <jwv39ud784y.fsf-monnier+emacs@gnu.org>

On Tue, Aug 17, 2010 at 2:11 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>>>> Line numbers should work even in multi major mode buffers. Please add
>>>> the following lines to linum.el:
>>>
>>>> (put 'linum-overlays  'permanent-local t)
>>>> (put 'linum-available 'permanent-local t)
>>>> (put 'linum-mode      'permanent-local t)
>>>
>>> I don't think that's going to be sufficient: you'll probably at least
>>> also want to remove the
>>>
>>>        (add-hook 'change-major-mode-hook 'linum-delete-overlays nil t)
>>>
>>> I.e. you can't just make some vars permanent-local, you have to adjust
>>> the major mode from "mode-specific" to "permanent-local".
>
>> Yes, I know. I have added code to take careof this for linum in
>> mumamo.el. But we do not yet have code in Emacs for taking care of
>> this more generally.
>
> But your report is about fixing it in linum.el (where it belongs), which
> means to turn linum-mode from a major-mode-specific minor-mode to
> a permanent-local major-mode.  I think such a change is acceptable
> (although the motivation of multi-major-mode buffers might not be that
> compelling, since it tends to lead to the idea that most/all
> minor-modes should be made permanent-local), but we need a proper patch
> for it.

How about also removing adding linum to change-major-mode-hook?





  reply	other threads:[~2010-08-17 12:35 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-08-17  2:06 bug#6871: Please make linum-mode per buffer, not per major mode Lennart Borgman
2010-08-17  8:59 ` Stefan Monnier
2010-08-17 11:23   ` Lennart Borgman
2010-08-17 12:11     ` Stefan Monnier
2010-08-17 12:35       ` Lennart Borgman [this message]
2010-08-18  7:19         ` Stefan Monnier
2010-08-19  4:29           ` Lennart Borgman
2010-08-19 12:13             ` Juanma Barranquero
2010-08-19 13:25               ` Lennart Borgman
2010-08-19 13:38                 ` Juanma Barranquero
2010-08-19 14:00                   ` Lennart Borgman
2010-08-19 14:40                     ` Juanma Barranquero
2010-08-19 21:23                       ` Lennart Borgman
2010-08-19 21:57                         ` Juanma Barranquero
2010-08-19 22:21                           ` Lennart Borgman
2010-08-20  9:05                             ` Eli Zaretskii
2010-08-19 22:43                         ` Stefan Monnier
2010-08-20  1:11                           ` Lennart Borgman
2010-08-20 12:59                             ` Stefan Monnier
2010-08-19 14:45                 ` Stefan Monnier
2010-08-19 21:19                   ` Lennart Borgman
2010-08-17 23:47 ` MON KEY
2010-08-18  0:14   ` Lennart Borgman
2010-08-18  7:20   ` Stefan Monnier
2010-08-19 17:49     ` MON KEY
2010-08-19 21:18       ` Lennart Borgman
2020-09-19 15:52 ` Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTikzLEzfpSR883FMtxxvZW=h4vbTRLNfGtWG6e1E@mail.gmail.com' \
    --to=lennart.borgman@gmail.com \
    --cc=6871@debbugs.gnu.org \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.