From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Francis Litterio <flitterio@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: Patch to fix ERC mode's IRC protocol logging
Date: Tue, 20 Jul 2010 05:22:53 +0200 [thread overview]
Message-ID: <AANLkTikyh_BGVV-L6yKpfFoZpQjJJ3uOe4SmWNm6q-EQ@mail.gmail.com> (raw)
In-Reply-To: <i5i67hkqj1ps.fsf@gmail.com>
2010/7/20 Francis Litterio <flitterio@gmail.com>:
> Deniz Dogan wrote:
>
>> 2010/7/19 Fran Litterio:
>> > The below patch fixes a problem in ERC where erc-toggle-debug-irc-protocol
>> > was not logging inbound protocol data. It also changes the key to interactively
>> > toggle protocol logging so that it doesn't interfere with View mode bindings.
>
>> Thank you! You should probably also send it to erc-discuss <at> gnu.org in
>> case the ERC mantainer doesn't read emacs-devel.
>
> Do patches for ERC have to go into the upstream ERC source first in
> order to make it into Emacs? I thought that since ERC was now part of
> Emacs, patches can go directly into the Emacs source.
I guess I have the same understanding as you, but it may be more
likely that you receive more feedback on the patch from erc-discuss.
--
Deniz Dogan
next prev parent reply other threads:[~2010-07-20 3:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-20 2:55 Patch to fix ERC mode's IRC protocol logging Francis Litterio
2010-07-20 3:22 ` Deniz Dogan [this message]
2010-08-04 17:27 ` Michael Olson
2010-08-08 22:14 ` Chong Yidong
-- strict thread matches above, loose matches on Subject: below --
2010-07-19 17:19 Fran Litterio
2010-07-19 23:21 ` Deniz Dogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikyh_BGVV-L6yKpfFoZpQjJJ3uOe4SmWNm6q-EQ@mail.gmail.com \
--to=deniz.a.m.dogan@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=flitterio@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.