From: Juanma Barranquero <lekktu@gmail.com>
To: Nathan Weizenbaum <nex342@gmail.com>
Cc: 6378@debbugs.gnu.org
Subject: bug#6378: all-completions Segfault
Date: Tue, 8 Jun 2010 18:41:07 +0200 [thread overview]
Message-ID: <AANLkTikxtOY7rjDFi5xYpfNWRdKsJHr1fim8V47LAryx@mail.gmail.com> (raw)
In-Reply-To: <AANLkTimXG8KLpCE8oINzI4btpgGQOc38SLAsHHY266XO@mail.gmail.com>
On Tue, Jun 8, 2010 at 17:46, Nathan Weizenbaum <nex342@gmail.com> wrote:
> (all-completions "" [])
>
> I think the problem is on line 1593 of src/minibuf.c, but my
> Emacs-innards-fu isn't good enough to attempt a fix.
minibuf.c:1617, at this code:
if (XSYMBOL (bucket)->next)
because bucket has been assigned random junk from the nonexistent item
at position 0 in COLLECTION.
It should be fixed with the attached patch.
Juanma
2010-06-08 Juanma Barranquero <lekktu@gmail.com>
* minibuf.c (Fall_completions): Check COLLECTION's size. (Bug#6378)
=== modified file 'src/minibuf.c'
--- src/minibuf.c 2010-01-13 08:35:10 +0000
+++ src/minibuf.c 2010-06-08 16:34:41 +0000
@@ -1591,5 +1591,5 @@
{
obsize = XVECTOR (collection)->size;
- bucket = XVECTOR (collection)->contents[index];
+ bucket = obsize ? XVECTOR (collection)->contents[index] : zero;
}
next prev parent reply other threads:[~2010-06-08 16:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 15:46 bug#6378: all-completions Segfault Nathan Weizenbaum
2010-06-08 16:37 ` Lawrence Mitchell
2010-06-08 20:30 ` Stefan Monnier
2010-06-09 5:13 ` Thierry Volpiatto
2010-06-09 6:13 ` Lennart Borgman
2010-06-09 7:23 ` Thierry Volpiatto
2010-06-09 8:51 ` Lennart Borgman
2010-06-09 10:05 ` Thierry Volpiatto
2010-06-09 11:43 ` Andreas Schwab
2010-06-09 12:01 ` Thierry Volpiatto
2010-06-09 12:13 ` Andreas Schwab
2010-06-09 6:18 ` Thierry Volpiatto
2010-06-09 9:09 ` Lawrence Mitchell
2010-06-08 16:41 ` Juanma Barranquero [this message]
2010-06-08 16:53 ` Juanma Barranquero
2010-06-08 18:58 ` Lennart Borgman
2010-06-08 19:08 ` Juanma Barranquero
2010-06-08 19:32 ` Lennart Borgman
2010-06-08 19:57 ` Juanma Barranquero
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTikxtOY7rjDFi5xYpfNWRdKsJHr1fim8V47LAryx@mail.gmail.com \
--to=lekktu@gmail.com \
--cc=6378@debbugs.gnu.org \
--cc=nex342@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.