From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#7190: Crash in menus on w32 Date: Wed, 13 Oct 2010 18:06:35 +0200 Message-ID: References: <4CB591BD.4060804@gmx.de> <4CB5BC32.1030008@gmx.de> <4CB5D576.8080100@gmx.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1286986676 4092 80.91.229.12 (13 Oct 2010 16:17:56 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 13 Oct 2010 16:17:56 +0000 (UTC) Cc: bug-gnu-emacs@gnu.org To: grischka Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 13 18:17:54 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1P641X-0000BS-NW for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Oct 2010 18:17:54 +0200 Original-Received: from localhost ([127.0.0.1]:46879 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P641L-0006js-Jg for geb-bug-gnu-emacs@m.gmane.org; Wed, 13 Oct 2010 12:17:39 -0400 Original-Received: from [140.186.70.92] (port=36039 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P63w8-0004V2-7c for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:12:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63w4-0005Rx-Cv for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:12:13 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56218) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63w4-0005Rs-Aj for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:12:12 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1P63oA-0004du-Fu; Wed, 13 Oct 2010 12:04:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 13 Oct 2010 16:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7190 X-GNU-PR-Package: emacs,w32 X-GNU-PR-Keywords: Original-Received: via spool by submit@debbugs.gnu.org id=B.128698581117839 (code B ref -1); Wed, 13 Oct 2010 16:04:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 13 Oct 2010 16:03:31 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P63nf-0004dg-I4 for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:03:31 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1P63nd-0004db-CM for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:03:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63r0-0004SP-IQ for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:06:59 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:42546) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63r0-0004SL-Ff for submit@debbugs.gnu.org; Wed, 13 Oct 2010 12:06:58 -0400 Original-Received: from [140.186.70.92] (port=36346 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1P63qz-0000rq-HR for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:58 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1P63qy-0004RV-1b for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:57 -0400 Original-Received: from mail-qw0-f41.google.com ([209.85.216.41]:65052) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1P63qx-0004RL-Vc for bug-gnu-emacs@gnu.org; Wed, 13 Oct 2010 12:06:56 -0400 Original-Received: by qwb8 with SMTP id 8so3365741qwb.0 for ; Wed, 13 Oct 2010 09:06:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=rD2ehQV4A1YOeJyOCsnOfxCCEyxjxcl6k/+zjIRnAOs=; b=kDXg2NkPKmuchLzxv/8CpFGlx+ZoeOvU+hcwH8mEdOyJiPhnBRXnmAVNkU4Y+Fhm3c FkWx0O/NM7Y8r8oee/7E7f4dPHNJBQeOOQBJxvQOcO/2SfSMQEyiz0tFQjlYVOhlW37r TEhAqsfGqy1azYDIcSNI2ga7iQ6IdkpM+mfas= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=bef+nCjQtcTBt3tgqZLzVZCsKHPNFkyZN8D5OtdMX/6lxtG5j12v/uQFVZEqPBkC5g WWGGXlLLm0sPtvfLdIjtBiutsYM9XS0kWnBHRIbWVwKAIA5UcNgAdRhVJzA+18ivu955 G86ogkptaGsP/gPi929dnl8QPC3XVzDrdXv/I= Original-Received: by 10.224.60.136 with SMTP id p8mr2778384qah.283.1286986015330; Wed, 13 Oct 2010 09:06:55 -0700 (PDT) Original-Received: by 10.229.220.195 with HTTP; Wed, 13 Oct 2010 09:06:35 -0700 (PDT) In-Reply-To: <4CB5D576.8080100@gmx.de> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 13 Oct 2010 12:04:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:40858 Archived-At: On Wed, Oct 13, 2010 at 5:51 PM, grischka wrote: > Lennart Borgman wrote: >>>> >>>> Is not that an important difference? >>> >>> Not if you want to fix the bug. >> >> It looks like I am thinking nearly exactly the opposite. >> >> For a simple bug it does not matter. For a complicated bug you can not >> look at all possible places. That would take too long time. So putting >> some structure on the different places and evaluating them makes much >> sense to me. > > This bug is simple. Didn't someone say life is easier for pessimists... ;-) >>>>>> By >>>>>> adding DebPrint call we could perhaps see if some code where called = in >>>>>> an order we did not expect. >>>>> >>>>> Perhaps see the information that you already have? =C2=A0For example >>>>> =C2=A0#7 =C2=A00x011c4e4b in w32_free_submenu_strings (menu=3D0x205e3= ) at >>>>> w32menu.c:1701 >>>>> is telling where is "some code", and >>>>> =C2=A0"Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )= " >>>>> is telling about "order we did not expect", as likely in: =C2=A0Calle= d >>>>> twice for the same memory object. =C2=A0If in doubt, try to prove tha= t >>>>> it can't happen. >>>> >>>> Yes, perhaps. But it could also be that memory objects are freed in an >>>> order we did not expect. >>>> >>> Why should it matter in what order "Invalid Address" is passed to free? >> >> Maybe I am misunderstanding, I do not know much about this part of the >> code. Are you saying that you could not get this error from calls to >> RtlFreeHeap coming in the wrong order? (That would perhaps help much >> to know.) > > Yes, =C2=A0RtlFreeHeap (like any free) doesn't care about order. =C2=A0It= only > cares that it's a valid object (which it isn't if it was already freed). > Did not someone see corrupted first letters in menu strings and such? > That is also a symptom of premature free, often. =C2=A0Count 1+1 ... Thanks, that helps. It makes it easier for me to put in some trace messages in useful places.