From: Lennart Borgman <lennart.borgman@gmail.com>
To: grischka <grishka@gmx.de>
Cc: bug-gnu-emacs@gnu.org
Subject: bug#7190: Crash in menus on w32
Date: Wed, 13 Oct 2010 18:06:35 +0200 [thread overview]
Message-ID: <AANLkTiktK_mnDVQjv-wAb=87HmGTW2+6JijNVBeX8qGe@mail.gmail.com> (raw)
In-Reply-To: <4CB5D576.8080100@gmx.de>
On Wed, Oct 13, 2010 at 5:51 PM, grischka <grishka@gmx.de> wrote:
> Lennart Borgman wrote:
>>>>
>>>> Is not that an important difference?
>>>
>>> Not if you want to fix the bug.
>>
>> It looks like I am thinking nearly exactly the opposite.
>>
>> For a simple bug it does not matter. For a complicated bug you can not
>> look at all possible places. That would take too long time. So putting
>> some structure on the different places and evaluating them makes much
>> sense to me.
>
> This bug is simple.
Didn't someone say life is easier for pessimists... ;-)
>>>>>> By
>>>>>> adding DebPrint call we could perhaps see if some code where called in
>>>>>> an order we did not expect.
>>>>>
>>>>> Perhaps see the information that you already have? For example
>>>>> #7 0x011c4e4b in w32_free_submenu_strings (menu=0x205e3) at
>>>>> w32menu.c:1701
>>>>> is telling where is "some code", and
>>>>> "Invalid Address specified to RtlFreeHeap( 00850000, 0088BDC8 )"
>>>>> is telling about "order we did not expect", as likely in: Called
>>>>> twice for the same memory object. If in doubt, try to prove that
>>>>> it can't happen.
>>>>
>>>> Yes, perhaps. But it could also be that memory objects are freed in an
>>>> order we did not expect.
>>>>
>>> Why should it matter in what order "Invalid Address" is passed to free?
>>
>> Maybe I am misunderstanding, I do not know much about this part of the
>> code. Are you saying that you could not get this error from calls to
>> RtlFreeHeap coming in the wrong order? (That would perhaps help much
>> to know.)
>
> Yes, RtlFreeHeap (like any free) doesn't care about order. It only
> cares that it's a valid object (which it isn't if it was already freed).
> Did not someone see corrupted first letters in menu strings and such?
> That is also a symptom of premature free, often. Count 1+1 ...
Thanks, that helps. It makes it easier for me to put in some trace
messages in useful places.
next prev parent reply other threads:[~2010-10-13 16:06 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 15:13 bug#7190: Crash in menus on w32 Lennart Borgman
2010-10-11 19:20 ` Eli Zaretskii
2010-10-11 21:21 ` Lennart Borgman
2010-10-12 4:04 ` Eli Zaretskii
2010-10-12 9:37 ` Lennart Borgman
2010-10-12 19:05 ` Eli Zaretskii
2010-10-12 19:13 ` Lennart Borgman
2010-10-12 19:40 ` Eli Zaretskii
2010-10-12 20:09 ` Lennart Borgman
2010-10-12 20:14 ` Eli Zaretskii
2010-10-12 20:49 ` Lennart Borgman
2010-10-13 11:30 ` Eli Zaretskii
2010-10-19 0:20 ` Lennart Borgman
2010-10-19 5:59 ` Eli Zaretskii
2010-10-19 10:33 ` Lennart Borgman
2010-10-13 11:02 ` grischka
2010-10-13 11:08 ` Lennart Borgman
2010-10-13 14:03 ` grischka
2010-10-13 14:43 ` Lennart Borgman
2010-10-13 15:51 ` grischka
2010-10-13 16:06 ` Lennart Borgman [this message]
2010-10-21 11:11 ` grischka
2010-10-21 15:27 ` Jason Rumney
2010-10-21 17:07 ` grischka
2010-10-22 14:09 ` Jason Rumney
2010-10-22 16:20 ` grischka
2010-11-08 1:49 ` Lennart Borgman
2010-11-08 10:15 ` grischka
2010-11-08 11:18 ` Lennart Borgman
2010-11-08 19:51 ` grischka
2010-11-08 23:11 ` Lennart Borgman
2010-11-09 16:16 ` grischka
2010-11-09 17:08 ` Eli Zaretskii
2010-11-09 18:39 ` grischka
[not found] ` <jwvpqueyy9i.fsf-monnier+emacs@gnu.org>
2010-11-10 10:33 ` grischka
2010-11-12 7:53 ` Glenn Morris
2010-11-12 22:40 ` grischka
2010-11-13 17:08 ` Chong Yidong
2013-02-18 2:23 ` Glenn Morris
2013-02-18 2:39 ` Lennart Borgman
2013-02-18 3:43 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTiktK_mnDVQjv-wAb=87HmGTW2+6JijNVBeX8qGe@mail.gmail.com' \
--to=lennart.borgman@gmail.com \
--cc=bug-gnu-emacs@gnu.org \
--cc=grishka@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.