From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Agustin Martin Newsgroups: gmane.emacs.bugs Subject: bug#6143: 6143 ispell not fixed Date: Thu, 29 Jul 2010 13:41:21 +0200 Message-ID: References: <87y6ftvphy.fsf@jidanni.org> <871vavtjqg.fsf@jidanni.org> <20100726093848.GA3291@agmartin.aq.upm.es> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1280405315 10816 80.91.229.12 (29 Jul 2010 12:08:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 29 Jul 2010 12:08:35 +0000 (UTC) Cc: jidanni@jidanni.org To: 6143@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Jul 29 14:08:34 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OeRuZ-00076i-03 for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jul 2010 14:08:32 +0200 Original-Received: from localhost ([127.0.0.1]:54952 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeRuX-0005h4-73 for geb-bug-gnu-emacs@m.gmane.org; Thu, 29 Jul 2010 08:08:29 -0400 Original-Received: from [140.186.70.92] (port=40942 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OeRuG-0005ai-Rt for bug-gnu-emacs@gnu.org; Thu, 29 Jul 2010 08:08:20 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OeRtr-0002Cd-3m for bug-gnu-emacs@gnu.org; Thu, 29 Jul 2010 08:07:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:47754) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeRtr-0002CZ-0t for bug-gnu-emacs@gnu.org; Thu, 29 Jul 2010 08:07:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OeRUw-0002kK-IN; Thu, 29 Jul 2010 07:42:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Agustin Martin Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Jul 2010 11:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6143 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6143-submit@debbugs.gnu.org id=B6143.128040367410546 (code B ref 6143); Thu, 29 Jul 2010 11:42:02 +0000 Original-Received: (at 6143) by debbugs.gnu.org; 29 Jul 2010 11:41:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeRU9-0002k3-RN for submit@debbugs.gnu.org; Thu, 29 Jul 2010 07:41:14 -0400 Original-Received: from mail-qw0-f44.google.com ([209.85.216.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OeRU7-0002jy-Qt for 6143@debbugs.gnu.org; Thu, 29 Jul 2010 07:41:12 -0400 Original-Received: by qwe5 with SMTP id 5so97071qwe.3 for <6143@debbugs.gnu.org>; Thu, 29 Jul 2010 04:41:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=IGki7mq7IApzfAn+HPaDr3cuuqTIoQlGTqZoXnSLKII=; b=dhRRGoD64AEu8PaSHHxEsXVlszBvelKjgL6/MzQILOYoOSYsah+JOpN3HbB6k9dIgZ 91kJvkYfytwCf3oAe3UV1Xdh4Gzq6YKX2oPcQ18YvmIIQkLXPg2ULBxMbyBw7riMTH7c BuC5QVBNVR7oEhiEMKMMJj3Ye8GDNXWbMV1H8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=gcNz48d0rpC/1s0Y1BOEbuCkq0Ysr59lTe5JA8k8dl7J6HeR2jnleoCFnr85bZXZ0D C2WifQm5l2jmP2u7CbWDAek3R3DtyaJhOirbBur2CbJzUoC9CqNxt00v/j1mE9ZXK7Dd u3SNAd0Ns3DFw7+8OAMliY8WKbX7GZzJsK5iI= Original-Received: by 10.224.105.199 with SMTP id u7mr9225038qao.131.1280403682059; Thu, 29 Jul 2010 04:41:22 -0700 (PDT) Original-Received: by 10.229.249.129 with HTTP; Thu, 29 Jul 2010 04:41:21 -0700 (PDT) In-Reply-To: X-Google-Sender-Auth: ihRfwO_kNnrCHSr8eDnFg7ynBT4 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 29 Jul 2010 07:42:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:39038 Archived-At: 2010/7/27 Dan Nicolaescu : > Agustin Martin writes: > >> On Sat, Jul 24, 2010 at 01:35:06AM -0400, Dan Nicolaescu wrote: >>> >>> You can get the "Ispell process killed" message by doing: >>> >>> $ echo $LANG >>> C >>> $ emacs -Q >>> M-: (add-hook 'text-mode-hook =A0 =A0 =A0 'flyspell-mode) RET >>> >>> C-x C-f A_FILE_UNDER_VERSION_CONTROL_FOR_EXAMPLE_MANAGED_BY_GIT >>> type something >>> C-x v v >>> type something in the log-edit buffer. >>> C-c C-c >>> >>> now look at the *Messages* buffer and see the "Ispell process killed" >> >> Strange, I get a different result (although also with an error), >> >> $ LANG=3DC LC_ALL=3DC emacs-snapshot -Q & >> M-: (add-hook 'text-mode-hook =A0 =A0 =A0 'flyspell-mode) RET >> C-x C-f A_FILE_UNDER_GIT_VERSION_CONTROL (kkk.txt) >> type something >> C-x v v >> type something in the log-edit buffer. >> >> =A0 Error during redisplay: (error No match 4 in highlight (4 font-lock-= warning-face)) >> >> C-c C-c >> >> =A0 Buffer kkk.txt modified; save it? (y or n) >> =A0 Error during redisplay: (error No match 4 in highlight (4 font-lock-= warning-face)) >> >> But no ispell process restart. > > When I ispell-kill-ispell is invoked the backtrace looks like this: > > =A0ispell-kill-ispell(t) > =A0(if (equal ispell-process-buffer-name (buffer-name)) (ispell-kill-ispe= ll t)) > =A0(lambda nil (if (equal ispell-process-buffer-name ...) (ispell-kill-is= pell t)))() > =A0kill-buffer(#) > =A0vc-finish-logentry() > =A0call-interactively(vc-finish-logentry) > =A0log-edit-done() > =A0call-interactively(log-edit-done nil nil) > > > So this is caused by: > > (add-hook 'kill-buffer-hook > =A0 =A0 =A0 =A0 =A0 =A0'(lambda () > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 (if (equal ispell-process-buffer-name (bu= ffer-name)) > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(ispell-kill-ispell t)))) > > > ispell-process-buffer-name is "*VC-log*" Thanks for debugging, Dan I guess your original A_FILE_UNDER_GIT_VERSION_CONTROL file is not a text-mode file. If so, this is the currently expected behavior, do not leave unused ispell processes behind. So, no ispell process is started for initial file, and only when you start the text mode buffer "*VC-log*", an ispell process is started. Since there was no previous process "owned" by a previous buffer, this is killed on buffer kill. Note that I was playing with a text file, so an ispell process is started for it and, since it does not contain neither localwords nor an explicit language different from default, same process is used for "*VC-log*" buffer and is not killed on "*VC-log*" kill since it was initiated from original buffer. That is the difference I find. What happened before for me is that I probably did not use the file as kkk.txt, but as plain kkk. This being too noisy or not is open for discussion, others may argue that leaving unused ispell processes behind is also a bug. I personally do not find this noisy enough. Opinions welcome. If this is considered too noisy and leaving unused ispell processes behind not a problem I think the way to go is to always use "~/" as ispell process directory, so problem with removable media that used the kill-on-kill gets also fixed. Better if there is a not too complicated way of having an exception when Ispell is the spellchecking engine and original directory contains an Ispell directory dictionary for given language. This way if using Ispell, current directory is used as ispell-default-directory only if contains appropriate directory personal dictionary and process is killed on buffer kill only if so (IIRC someone already proposed this, but I do not find original mail). Otherwise we lose support for this Ispell funcionality. Have to think a bit about this. PS: I have been lately with limited time and connectivity. Do not expect something quickly. --=20 Agustin