all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Deniz Dogan <deniz.a.m.dogan@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 7921@debbugs.gnu.org, Evan Owens <eaowens@gmail.com>
Subject: bug#7921: 23.2.91; js-mode font lock problem with comments
Date: Thu, 27 Jan 2011 18:33:56 +0100	[thread overview]
Message-ID: <AANLkTikkHUGtHhf+iRbmb1jTyuJg-uQ3oRAastWf34x1@mail.gmail.com> (raw)
In-Reply-To: <jwv39oel0ur.fsf-monnier+emacs@gnu.org>

2011/1/27 Stefan Monnier <monnier@iro.umontreal.ca>:
>>>> path=/";/ # Everything following and including the last / is string face
>>>> path="; # Everything is fine
>>>> path=//"; # Everything is fine
>>>
>>> I've put the above three lines in ~/tmp/foo.js and opened it with
>>> Debian's emacs23 and I don't think I see the problems you describe in
>>> the comments.  OTOH I see other problems of highlighting but they're
>>> largely due to the code itself being meaningless, AFAIK (# is not
>>> a comment marker in javascript, is it?).
>>>
>
>> I'm sorry, I should have been more clear. The # signs are
>> meta-comments, please leave them out when trying to reproduce the
>> problem.
>
> In my tests, the ";\npath=//" is treated as a string.  This sounds right
> to me, but not being a js-programmer, your example makes me doubt.
> IOW, using the latest code in the emacs-23, are there still some issues
> with js-mode's font-locking?
>

Assuming that you mean "; npath=//", it is indeed correctly fontified
as a string.

I notice now that I referred to the three JavaScript examples as
"issues" -- they are not issues.

Only the last two examples are valid JavaScript. The first example,
even though _invalid_ JavaScript, might give us a hint about what the
problem is. That is the only reason why I included it.

-- 
Deniz Dogan





  reply	other threads:[~2011-01-27 17:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-26 14:56 bug#7921: 23.2.91; js-mode font lock problem with comments Evan Owens
2011-01-26 17:43 ` Deniz Dogan
2011-01-26 17:50   ` Deniz Dogan
2011-01-26 19:30   ` Lennart Borgman
2011-01-27  3:22   ` Stefan Monnier
2011-01-27  3:26     ` Deniz Dogan
2011-01-27 17:22       ` Stefan Monnier
2011-01-27 17:33         ` Deniz Dogan [this message]
2016-02-07 20:23           ` Simen Heggestøyl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AANLkTikkHUGtHhf+iRbmb1jTyuJg-uQ3oRAastWf34x1@mail.gmail.com \
    --to=deniz.a.m.dogan@gmail.com \
    --cc=7921@debbugs.gnu.org \
    --cc=eaowens@gmail.com \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.