bug#8183: isearch yanking

bug#8183: isearch yanking

[gnu.emacs.bug]

Hello!

I just spent a while trying to track down a bug in isearch.el that
turned out to be a "feature".  C-y has been hijacked to do some weird
thing where it pastes the entire next line of the buffer instead of
the kill ring. (Wacky!)

Please change it so that C-y works normally.

While I'm sure there's someone in the world who has a use for
searching for the entire next line, there are many, many more people
who find it useful to search for items from the kill ring.

Additionally, the way isearch is remapping the C-y key breaks Emacs's
consistency.  One of the wonderful things about Emacs is that it is
not modal.  The basic keys always work the same regardless of what
"mode" you are in.

If you are not convinced, please consider that cut and paste is
fundamental to Emacs.  C-y is so basic to how Emacs functions that
it's been listed in the Emacs tutorial (C-h t) for a quarter century.
The keybindings mentioned in the tutorial shouldn't be altered
lightly.

And finally, think about what a pain it is to teach people new to
Emacs that C-y works as yank and M-y is yank-pop, EXCEPT when doing a
search where M-y is yank and there is no way to do a yank-pop.  This
one small quirk has added work not only on to people who are trying to
learn Emacs, but on to the people teaching Emacs and trying to write
easy to understand documentation and tutorials.

Fortunately, the fix for this is easy. In isearch.el, just change the
line that defines C-y as isearch-yank-line to isearch-yank-kill.

-    (define-key map    "\C-y" 'isearch-yank-line)
+    (define-key map    "\C-y" 'isearch-yank-kill)

Thank you,

--B. Wong

bug#8183: isearch yanking

[Chong Yidong]

gnu.emacs.bug@wongs.net writes:

> I just spent a while trying to track down a bug in isearch.el that
> turned out to be a "feature".  C-y has been hijacked to do some weird
> thing where it pastes the entire next line of the buffer instead of
> the kill ring. (Wacky!)

> Fortunately, the fix for this is easy. In isearch.el, just change the
> line that defines C-y as isearch-yank-line to isearch-yank-kill.

This has been bugging me, and has been discussed before, e.g.

  http://lists.gnu.org/archive/html/emacs-devel/2008-11/msg00485.html

Back in that 2008 thread, Juri Linkov suggested exactly this change, and
moving isearch-yank-line over to M-s C-e.

Nothing seemed to come of that suggestion, maybe due to simple inertia.
I now propose to make it so.  Any objections?

Re: bug#8183: isearch yanking

[Chong Yidong]

gnu.emacs.bug@wongs.net writes:

> I just spent a while trying to track down a bug in isearch.el that
> turned out to be a "feature".  C-y has been hijacked to do some weird
> thing where it pastes the entire next line of the buffer instead of
> the kill ring. (Wacky!)

> Fortunately, the fix for this is easy. In isearch.el, just change the
> line that defines C-y as isearch-yank-line to isearch-yank-kill.

This has been bugging me, and has been discussed before, e.g.

  http://lists.gnu.org/archive/html/emacs-devel/2008-11/msg00485.html

Back in that 2008 thread, Juri Linkov suggested exactly this change, and
moving isearch-yank-line over to M-s C-e.

Nothing seemed to come of that suggestion, maybe due to simple inertia.
I now propose to make it so.  Any objections?

Re: bug#8183: isearch yanking

[Lennart Borgman]

On Sun, Mar 6, 2011 at 1:23 AM, Chong Yidong <cyd@stupidchicken.com> wrote:
> gnu.emacs.bug@wongs.net writes:
>
>> I just spent a while trying to track down a bug in isearch.el that
>> turned out to be a "feature".  C-y has been hijacked to do some weird
>> thing where it pastes the entire next line of the buffer instead of
>> the kill ring. (Wacky!)
>
>> Fortunately, the fix for this is easy. In isearch.el, just change the
>> line that defines C-y as isearch-yank-line to isearch-yank-kill.
>
> This has been bugging me, and has been discussed before, e.g.
>
>  http://lists.gnu.org/archive/html/emacs-devel/2008-11/msg00485.html
>
> Back in that 2008 thread, Juri Linkov suggested exactly this change, and
> moving isearch-yank-line over to M-s C-e.
>
> Nothing seemed to come of that suggestion, maybe due to simple inertia.
> I now propose to make it so.  Any objections?

It might have stalled because we where discussing other changes to
isearch keymap, but I can see no reason to not make the proposed
change here.

bug#8183: isearch yanking

[Lennart Borgman]

On Sun, Mar 6, 2011 at 1:23 AM, Chong Yidong <cyd@stupidchicken.com> wrote:
> gnu.emacs.bug@wongs.net writes:
>
>> I just spent a while trying to track down a bug in isearch.el that
>> turned out to be a "feature".  C-y has been hijacked to do some weird
>> thing where it pastes the entire next line of the buffer instead of
>> the kill ring. (Wacky!)
>
>> Fortunately, the fix for this is easy. In isearch.el, just change the
>> line that defines C-y as isearch-yank-line to isearch-yank-kill.
>
> This has been bugging me, and has been discussed before, e.g.
>
>  http://lists.gnu.org/archive/html/emacs-devel/2008-11/msg00485.html
>
> Back in that 2008 thread, Juri Linkov suggested exactly this change, and
> moving isearch-yank-line over to M-s C-e.
>
> Nothing seemed to come of that suggestion, maybe due to simple inertia.
> I now propose to make it so.  Any objections?

It might have stalled because we where discussing other changes to
isearch keymap, but I can see no reason to not make the proposed
change here.

Re: bug#8183: isearch yanking

[Stefan Monnier]

> Nothing seemed to come of that suggestion, maybe due to simple inertia.
> I now propose to make it so.  Any objections?

Please go ahead,


        Stefan

Re: bug#8183: isearch yanking

[Dani Moncayo]

On Sun, Mar 6, 2011 at 06:33, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Nothing seemed to come of that suggestion, maybe due to simple inertia.
>> I now propose to make it so.  Any objections?
>
> Please go ahead,
>

FWIW, this bug is a duplicate of #7700.

...and what about M-y? If we are looking for consistency, M-y should
also DTRT, i.e., replace the just-yanked (in the Isearch prompt) text
with an earlier entry from the kill-ring.


Regards,

-- 
Dani Moncayo

bug#8183: isearch yanking

[Dani Moncayo]

On Sun, Mar 6, 2011 at 06:33, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>> Nothing seemed to come of that suggestion, maybe due to simple inertia.
>> I now propose to make it so.  Any objections?
>
> Please go ahead,
>

FWIW, this bug is a duplicate of #7700.

...and what about M-y? If we are looking for consistency, M-y should
also DTRT, i.e., replace the just-yanked (in the Isearch prompt) text
with an earlier entry from the kill-ring.


Regards,

-- 
Dani Moncayo

bug#8183: isearch yanking

[Stefan Monnier]

> Nothing seemed to come of that suggestion, maybe due to simple inertia.
> I now propose to make it so.  Any objections?

Please go ahead,


        Stefan