bug#7133: Please check return value from shell-command in org-latex.el

bug#7133: Please check return value from shell-command in org-latex.el

[Lennart Borgman]

[-- Attachment #1: Type: text/plain, Size: 325 bytes --]

When output goes to a specified buffer (instead of current buffer) it
is possible to check the return value from shell-command. I suggest
doing that in org-latex.diff, see attached file.

I think the doc string of shell-command should be updated too since it
does not mention that you can test the return value in this case.

[-- Attachment #2: org-latex-shell-command-check.diff --]
[-- Type: application/octet-stream, Size: 596 bytes --]

=== modified file 'lisp/org/org-latex.el'
--- trunk/lisp/org/org-latex.el	2010-07-19 09:47:27 +0000
+++ patched/lisp/org/org-latex.el	2010-09-29 15:52:48 +0000
@@ -849,7 +849,9 @@
 		     (save-match-data
 		       (shell-quote-argument file))
 		     t t cmd)))
-	(shell-command cmd outbuf outbuf)))
+	(unless (= 0 (shell-command cmd outbuf outbuf))
+          (display-buffer outbuf)
+          (error "Error in subprocess, see %s; cmd=%S" outbuf cmd))))
     (message "Processing LaTeX file...done")
     (if (not (file-exists-p pdffile))
 	(error "PDF file was not produced")