* Problematic change in ebrowse.c
@ 2010-07-03 8:04 Eli Zaretskii
2010-07-03 10:54 ` Juanma Barranquero
0 siblings, 1 reply; 2+ messages in thread
From: Eli Zaretskii @ 2010-07-03 8:04 UTC (permalink / raw)
To: Juanma Barranquero; +Cc: emacs-devel
This change (part of revno 100699):
=== modified file 'lib-src/ebrowse.c'
--- lib-src/ebrowse.c 2010-07-03 00:50:23 +0000
+++ lib-src/ebrowse.c 2010-07-03 07:44:17 +0000
@@ -2385,7 +2385,7 @@ match_qualified_namespace_alias (void)
{
case IDENT:
tmp = (struct link *) xmalloc (sizeof *cur);
- tmp->sym = find_namespace (yytext, cur);
+ tmp->sym = find_namespace (yytext, cur->sym);
tmp->next = NULL;
if (head)
{
might crash at run time, because we are dereferencing `cur' which
could be a NULL pointer.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Problematic change in ebrowse.c
2010-07-03 8:04 Problematic change in ebrowse.c Eli Zaretskii
@ 2010-07-03 10:54 ` Juanma Barranquero
0 siblings, 0 replies; 2+ messages in thread
From: Juanma Barranquero @ 2010-07-03 10:54 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
On Sat, Jul 3, 2010 at 10:04, Eli Zaretskii <eliz@gnu.org> wrote:
> This change (part of revno 100699):
> might crash at run time, because we are dereferencing `cur' which
> could be a NULL pointer.
Yes, I realized a while after committing the change (but I don't have
internet connection on the shower so I had to wait).
Fixed now, thanks.
Juanma
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-07-03 10:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-07-03 8:04 Problematic change in ebrowse.c Eli Zaretskii
2010-07-03 10:54 ` Juanma Barranquero
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.