From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: stop using P_, __P in header files Date: Sun, 4 Jul 2010 18:26:40 +0200 Message-ID: References: <4C2DB1E0.7010305@swipnet.se> <83aaqa9ml7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1278260837 20377 80.91.229.12 (4 Jul 2010 16:27:17 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Jul 2010 16:27:17 +0000 (UTC) Cc: Eli Zaretskii , =?UTF-8?Q?Jan_Dj=C3=A4rv?= , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 04 18:27:14 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVS2D-0006kC-9F for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 18:27:13 +0200 Original-Received: from localhost ([127.0.0.1]:50708 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVS2B-0003aH-Kb for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 12:27:11 -0400 Original-Received: from [140.186.70.92] (port=44097 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVS24-0003aC-U3 for emacs-devel@gnu.org; Sun, 04 Jul 2010 12:27:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVS23-0006KU-MR for emacs-devel@gnu.org; Sun, 04 Jul 2010 12:27:04 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:38538) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVS21-0006K1-S7; Sun, 04 Jul 2010 12:27:01 -0400 Original-Received: by bwz9 with SMTP id 9so3003048bwz.0 for ; Sun, 04 Jul 2010 09:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=O4x7/X364MYX0V6w05Hjo19mkxo26xZIftXpQQFA3YQ=; b=qIlzwJtpFHLWBM+++UFPAJa/LO2/NZwYTFLGl0ILM8tZisG0bLq+rN05ZlvCDTVSFF 1gfmGfNtVEX651r/fv139aC49pkk5svVhpPoacRs+qOu2D47aCCjGYYj/twOR9hoPYwf jEemPg3EBRg1mDcfjQzPxapda6wmbRH1tKSgs= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=cCrt1xe1819Zv09eWVtCwSjIda83jlr6tR/U+2Q2lB+37OSgX7y6hliIPu437JOSrA sgsUJ26dp3xR/dgr+AeOk7zc29cnvBSTf2zVQm9vb6IqGKH2YZv2bIKzV2CVkMuccCDG ucuIzrzrdPaJqqMYLuONF9ugwu6DPUXhMvWXI= Original-Received: by 10.204.70.201 with SMTP id e9mr1448660bkj.141.1278260820139; Sun, 04 Jul 2010 09:27:00 -0700 (PDT) Original-Received: by 10.204.53.204 with HTTP; Sun, 4 Jul 2010 09:26:40 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126748 Archived-At: On Sun, Jul 4, 2010 at 17:55, Dan Nicolaescu wrote: > Yes, they should. =C2=A0I did not convert the code by hand, but by using > protoize (which runs the preprocessor) so this is why such prototypes got= changed. OK, committed. > I'd say we should resync with gnulib. > protoize made this change, so it was not intentional... Because of the different syntax in prototypes versus K&R, instead of LOCALE_PARAM_DECLR we should now use LOCALE_PARAM_PROTO -memcpy_lowcase (char *dest, const char *src, size_t len) +memcpy_lowcase (CHAR_T *dest, const CHAR_T *src, size_t len + LOCALE_PARAM_PROTO) -memcpy_uppcase (char *dest, const char *src, size_t len) +memcpy_uppcase (CHAR_T *dest, const CHAR_T *src, size_t len + LOCALE_PARAM_PROTO) which is a bit weird because it goes against the LOCALE_PARAM* use on strftime.c. It would be possible to redefine L_P_DECL: # define LOCALE_PARAM_DECL , __locale_t loc and keep the old code, but there are other functions in the file that have not been converted. As strftime.c is maintained outside of Emacs, I'd suggest just reverting the change and leaving the K&R code as it was. Seems cleaner that a mixup of styles. Juanma