From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: stop using P_, __P in header files Date: Sun, 4 Jul 2010 17:35:46 +0200 Message-ID: References: <4C2DB1E0.7010305@swipnet.se> <83aaqa9ml7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1278257783 11723 80.91.229.12 (4 Jul 2010 15:36:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Jul 2010 15:36:23 +0000 (UTC) Cc: Eli Zaretskii , =?UTF-8?Q?Jan_Dj=C3=A4rv?= , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 04 17:36:18 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVREw-0002v4-AJ for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 17:36:18 +0200 Original-Received: from localhost ([127.0.0.1]:37550 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVREu-0002em-PE for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 11:36:16 -0400 Original-Received: from [140.186.70.92] (port=47070 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVREp-0002eh-8X for emacs-devel@gnu.org; Sun, 04 Jul 2010 11:36:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVREo-0007Y8-7I for emacs-devel@gnu.org; Sun, 04 Jul 2010 11:36:11 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:57889) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVREl-0007Xh-OO; Sun, 04 Jul 2010 11:36:07 -0400 Original-Received: by bwz9 with SMTP id 9so2986039bwz.0 for ; Sun, 04 Jul 2010 08:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=VIhQf41cPf0wY1SGbYsDtvk1v5gdOMnr7w0qsGCbSTI=; b=eQJsTL8wW8I7+3yRHaocEOmgPAJp6Pjqs+ka+awD9tMA7RGeqtyJWpMhP/5wBiGYel G1airI8SXQrJkVWYrqPRqcTy+0uxBYHhTFmoMr7t2lSqdNHcB6iXNq541E2loz1hVB+r Ru+LOmZB6HvxefDkP0RA2N/R5Hyz0tCWEN2Mk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=vUM3+L0j9h/6hyO5OfN039szan8XZdkoPQJfFq/qLR6lSONPkD82E4H54XqmfzZNXB LPdIOfEwNl44mlxCtzDX1yoKASn/Y0gvuZt0MV8cqWj3ukGECHi0+3UghGCtjWWKHcYx P7kkL9TeTGyg8on0snWmaEl8Pe8ElGjbc8u7g= Original-Received: by 10.204.47.38 with SMTP id l38mr1009554bkf.154.1278257766124; Sun, 04 Jul 2010 08:36:06 -0700 (PDT) Original-Received: by 10.204.53.204 with HTTP; Sun, 4 Jul 2010 08:35:46 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126746 Archived-At: On Sun, Jul 4, 2010 at 10:08, Dan Nicolaescu wrote: > I've done most of this. Thanks. I've fixed a few prototypes that break compilation on Windows or generate warnings. A few questions: 1) This one and similar ones on unexelf.c seem errors: -round_up (x, y) - ElfW(Addr) x, y; +round_up (Elf32_Addr x, Elf32_Addr y) The prototypes should presumably still use ElfW(Addr), ElfW(Ehdr), etc., shouldn't they? 2) In strftme.c you've converted just some functions, not all, and removed the LOCALE_PARAM* macros. static CHAR_T * -memcpy_lowcase (dest, src, len LOCALE_PARAM) - CHAR_T *dest; - const CHAR_T *src; - size_t len; - LOCALE_PARAM_DECL +memcpy_lowcase (char *dest, const char *src, size_t len) Apparently, there haven't been any changes from gnulib merged back into strftime.c in the past seven years (since 2003-06-24). Should the LOCALE_PARAM* macros still be used (and so, re-added to memcpy_(low|upp)case), or would it be better to just get rid of that cruft? 3) After this change in print.c static void -strout (ptr, size, size_byte, printcharfun, multibyte) - char *ptr; - int size, size_byte; - Lisp_Object printcharfun; - int multibyte; +strout (char *ptr, int size, int size_byte, Lisp_Object printcharfun, int multibyte) { compilation throws this warning: print.c: In function 'print_object': print.c:1973: warning: passing argument 1 of 'strout' discards qualifiers from pointer target type print.c:353: note: expected 'char *' but argument is of type 'const char *' becase of the call strout (XSUBR (obj)->symbol_name, -1, -1, printcharfun, 0); AFAICS, the object pointed to by PTR is never modified, so it seems safe to use const char *, and I've done so. Juanma