From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: `C-h v' may offer too many symbols Date: Thu, 10 Mar 2011 20:39:48 +0100 Message-ID: References: <87y64mkdu3.fsf@lifelogs.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1299786043 19499 80.91.229.12 (10 Mar 2011 19:40:43 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 10 Mar 2011 19:40:43 +0000 (UTC) Cc: emacs-devel@gnu.org To: Ted Zlatanov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Mar 10 20:40:39 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Pxliu-0007hO-6n for ged-emacs-devel@m.gmane.org; Thu, 10 Mar 2011 20:40:36 +0100 Original-Received: from localhost ([127.0.0.1]:38751 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pxlit-0005Bk-Oz for ged-emacs-devel@m.gmane.org; Thu, 10 Mar 2011 14:40:35 -0500 Original-Received: from [140.186.70.92] (port=34776 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Pxlin-0005Bb-T0 for emacs-devel@gnu.org; Thu, 10 Mar 2011 14:40:30 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Pxlim-0002Kb-Rw for emacs-devel@gnu.org; Thu, 10 Mar 2011 14:40:29 -0500 Original-Received: from mail-yw0-f41.google.com ([209.85.213.41]:35066) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Pxlim-0002KU-IW for emacs-devel@gnu.org; Thu, 10 Mar 2011 14:40:28 -0500 Original-Received: by yws5 with SMTP id 5so1090712yws.0 for ; Thu, 10 Mar 2011 11:40:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=x8rU3V0t2X5gxy5i8gcrlDAviFRR0sQ2A1O3cUrJRrw=; b=AOm4WmO+wP2wzeU1jgfMEbaq09Wb29f9b8XdFaUH6PwdVqsLC0AvOgfKMSyxdrCb4R 8e/nRWBMdMvUvdKPU2U+m1H10iWcWBZW+2cT3106eIT4mxYfgLiQ+Ne/UgcvGOPplHki wvSqY5YT/pyqMfjijO3tu1ttx2Zf1R81Gmju4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=kw+otiihYlRES/q0zdV7t7czkk1LWNOAM64ZsthpzZhttJu8M7IXXgpVNk7oO9LIQR STciLRC7N7BwBbBrCwm1cvsdA30kK/BdCHXyG93UsjEkS7BnB7jVFuVlsfQjs+Jdjcxb W600ok5aiQGQK0/n8+bVZuDTeaQmtO/P1kYzw= Original-Received: by 10.236.181.163 with SMTP id l23mr1654830yhm.153.1299786028165; Thu, 10 Mar 2011 11:40:28 -0800 (PST) Original-Received: by 10.147.137.2 with HTTP; Thu, 10 Mar 2011 11:39:48 -0800 (PST) In-Reply-To: <87y64mkdu3.fsf@lifelogs.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.213.41 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:137059 Archived-At: 2011/3/10 Ted Zlatanov : > `C-h v' offers completion candidates like :AFTER and :border which are > not documented and self-quoting. =C2=A0Is that a good idea? =C2=A0They do= n't seem > useful to me. =C2=A0Maybe at least self-quoting symbols without a docstri= ng > should be excluded. Yes, it is a bit silly complete keywords, which are not variables by defini= tion. I'm going to install this trivial fix. =C2=A0 =C2=A0 Juanma 2011-03-10 Juanma Barranquero * help-fns.el (describe-variable): Don't complete keywords. Suggested by Teodor Zlatanov . =3D=3D=3D modified file 'lisp/help-fns.el' --- lisp/help-fns.el 2011-02-24 08:26:25 +0000 +++ lisp/help-fns.el 2011-03-10 19:32:46 +0000 @@ -593,8 +593,9 @@ "Describe variable: ") obarray '(lambda (vv) - (or (boundp vv) - (get vv 'variable-documentation))) + (unless (keywordp vv) + (or (boundp vv) + (get vv 'variable-documentation)))) t nil nil (if (symbolp v) (symbol-name v)))) (list (if (equal val "")