Enhancement to hideif.el

Enhancement to hideif.el

[Joe Matarazzo]

Hi,

I added an enhancement to hideif.el, based on the 22.3.1 windows
distribution of Emacs, to recognize  the #elif preprocessor directive.
I would like to contribute this improvement for future distributions.
I tried contacting the listed maintainer of this library, Daniel
LaLiberte (liberte@a.cs.uiuc.edu), but didn't receive a response.

Is there someone else I should follow up with to review these changes,
and potentially get them incorporated?

Thanks,
Joe

Re: Enhancement to hideif.el

[Stefan Monnier]

> I added an enhancement to hideif.el, based on the 22.3.1 windows
> distribution of Emacs, to recognize  the #elif preprocessor directive.
> I would like to contribute this improvement for future distributions.
> I tried contacting the listed maintainer of this library, Daniel
> LaLiberte (liberte@a.cs.uiuc.edu), but didn't receive a response.

The file's "Maintainer" lists "FSF" (the "Author" part is just
historical information), so this is the right place.

> Is there someone else I should follow up with to review these changes,
> and potentially get them incorporated?

You can send it via M-x report-emacs-bug, or just send it here.


        Stefan

Re: Enhancement to hideif.el

[Joe Matarazzo]

[-- Attachment #1: Type: text/plain, Size: 924 bytes --]

Hi - I've attached both a patch file and the modified version.

I look forward to any feedback you might have to offer.

Thanks,
Joe

On Wed, Nov 11, 2009 at 8:13 PM, Stefan Monnier
<monnier@iro.umontreal.ca> wrote:
>> I added an enhancement to hideif.el, based on the 22.3.1 windows
>> distribution of Emacs, to recognize  the #elif preprocessor directive.
>> I would like to contribute this improvement for future distributions.
>> I tried contacting the listed maintainer of this library, Daniel
>> LaLiberte (liberte@a.cs.uiuc.edu), but didn't receive a response.
>
> The file's "Maintainer" lists "FSF" (the "Author" part is just
> historical information), so this is the right place.
>
>> Is there someone else I should follow up with to review these changes,
>> and potentially get them incorporated?
>
> You can send it via M-x report-emacs-bug, or just send it here.
>
>
>        Stefan
>

[-- Attachment #2: hideif.zip --]
[-- Type: application/zip, Size: 12978 bytes --]

bug#5013: Enhancement to hideif.el

[Tony Hecker]

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

Hi,
I tested the hideif.el patch from Joe.  It works in some cases but does not
seem to work with a series of #elif's like this case:
#if 0
   function1();
#elif 1
   function2();  // should not be hidden but is hidden
#elif 0
   function3();
#elif 0
   function4();
#endif

I do not have a fix (at least not right now).

Thanks,
Tony

[-- Attachment #2: Type: text/html, Size: 391 bytes --]

bug#5013: Enhancement to hideif.el

[Lars Ingebrigtsen]

Joe Matarazzo <joe.matarazzo@gmail.com> writes:

> Severity: wishlist
> Tags: patch
>
> [ Resent from
>   http://lists.gnu.org/archive/html/emacs-devel/2009-11/msg00426.html ]
>
> Hi - I've attached both a patch file and the modified version.
>
> I look forward to any feedback you might have to offer.

[...]

> ;;; hideif.el --- hides selected code within ifdef
>
> ;; Copyright (C) 1988, 1994, 2001, 2002, 2003, 2004, 2005, 2006, 2007, 2008
> ;; Free Software Foundation, Inc.

Included was the entire changed version of hideif.el, so it's difficult
to review.  If this is still an issue all these years later, could you
submit a patch instead?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

bug#5013: Enhancement to hideif.el

[Andreas Schwab]

Lars Ingebrigtsen <larsi@gnus.org> writes:

> submit a patch instead?

The patch was included.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#5013: Enhancement to hideif.el

[Lars Ingebrigtsen]

Joe Matarazzo <joe.matarazzo@gmail.com> writes:

>  (defun hif-ifdef-to-endif ()
> -  "If positioned at #ifX or #else form, skip to corresponding #endif."
> +  "If positioned at #ifX, #elif, or #else form, skip to corresponding #endif."
>    ;; (message "hif-ifdef-to-endif at %d" (point)) (sit-for 1)
>    (hif-find-next-relevant)
>    (cond ((hif-looking-at-ifX)
>  	 (hif-ifdef-to-endif) ; find endif of nested if
>  	 (hif-ifdef-to-endif)) ; find outer endif or else
> +        ((hif-looking-at-elif)
> +         (hif-ifdef-to-endif))
>  	((hif-looking-at-else)
>  	 (hif-ifdef-to-endif)) ; find endif following else
>  	((hif-looking-at-endif)
> @@ -585,11 +590,14 @@
>    (cond ((hif-looking-at-endif)
>  	 (hif-endif-to-ifdef) ; find beginning of nested if
>  	 (hif-endif-to-ifdef)) ; find beginning of outer if or else
> +	((hif-looking-at-elif)
> +	 (hif-endif-to-ifdef))
>  	((hif-looking-at-else)
>  	 (hif-endif-to-ifdef))
>  	((hif-looking-at-ifX)
>  	 'done)
> -	(t)))			; never gets here
> +	(t
> +         (error "Mismatched #endif"))))			; never gets here

This looks very much like the code currently in hideif.el, so I guess
this was applied already?  Closing.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no