From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] /srv/bzr/emacs/trunk r100984: Remove extern declarations in .c files, .h files have them. Date: Fri, 6 Aug 2010 02:39:04 +0200 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1281055175 31194 80.91.229.12 (6 Aug 2010 00:39:35 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Aug 2010 00:39:35 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 06 02:39:33 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OhAyC-0005XM-D4 for ged-emacs-devel@m.gmane.org; Fri, 06 Aug 2010 02:39:32 +0200 Original-Received: from localhost ([127.0.0.1]:56576 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhAyB-00079W-O6 for ged-emacs-devel@m.gmane.org; Thu, 05 Aug 2010 20:39:31 -0400 Original-Received: from [140.186.70.92] (port=53411 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OhAy6-00079R-0A for emacs-devel@gnu.org; Thu, 05 Aug 2010 20:39:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OhAy5-0006jb-2V for emacs-devel@gnu.org; Thu, 05 Aug 2010 20:39:25 -0400 Original-Received: from mail-iw0-f169.google.com ([209.85.214.169]:53885) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OhAy4-0006jU-Uc for emacs-devel@gnu.org; Thu, 05 Aug 2010 20:39:25 -0400 Original-Received: by iwn10 with SMTP id 10so862720iwn.0 for ; Thu, 05 Aug 2010 17:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=FjwrRojqfXrs8c3kGzDE/4Ycle9Pkx2z96LnQ5tKIMU=; b=Ed49QByHPPs97eQXz8srRQw5YmUV58JKL7QbNk32/u1xpiKibvC1YPBsrCXDR5u2KZ pPCODcjlIEuv0OeVAz4G+Eiy36pJ1iAzyi19u6uaWTjXFEud92JRk12c/4QQ/q33tGgx BN7DxHu3oV5j4ewYTLMfrcPvzaYEtM7g3RJQw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=lzL3BgvQMciMLaezJCbJWtgg4KpkmHjTXTfaskXu+2sVpL+Y7l/LvR5FhhasMHfC5G OTiDhT5TEmOXHf1FEBIx4r3pO00svMPOVj4HRa6OsYYau+tQL2XbfkEUdTdyMXELMimC JJyFQ10R27xFI/z/eWTfkLiDQmbwasF2y7zAA= Original-Received: by 10.231.59.1 with SMTP id j1mr13047580ibh.55.1281055164195; Thu, 05 Aug 2010 17:39:24 -0700 (PDT) Original-Received: by 10.231.162.4 with HTTP; Thu, 5 Aug 2010 17:39:04 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:128331 Archived-At: > -/* Returns a search buffer, with a fastmap allocated and ready to go. = =C2=A0*/ > -extern struct re_pattern_buffer *compile_pattern (Lisp_Object, struct re= _registers *, Lisp_Object, int, int); > - I've reverted this bit because compile_pattern is not in any .h file, so it caused a warning. > -/* For NS and NTGUI, these prototypes are defined in keyboard.h. =C2=A0*= / > =C2=A0#if defined (USE_X_TOOLKIT) || defined (USE_GTK) > =C2=A0extern widget_value *xmalloc_widget_value (void); > =C2=A0extern widget_value *digest_single_submenu (int, int, int); There were not on menu.h, so I've moved the declaration there and removed it from here. =C2=A0 =C2=A0 Juanma