From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juanma Barranquero Newsgroups: gmane.emacs.devel Subject: Re: stop using P_, __P in header files Date: Mon, 5 Jul 2010 02:05:50 +0200 Message-ID: References: <4C2DB1E0.7010305@swipnet.se> <83aaqa9ml7.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1278289242 10486 80.91.229.12 (5 Jul 2010 00:20:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 5 Jul 2010 00:20:42 +0000 (UTC) Cc: Eli Zaretskii , =?UTF-8?Q?Jan_Dj=C3=A4rv?= , emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 05 02:20:41 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OVZQN-0008EM-Vy for ged-emacs-devel@m.gmane.org; Mon, 05 Jul 2010 02:20:40 +0200 Original-Received: from localhost ([127.0.0.1]:42805 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVZD6-0002qv-Ct for ged-emacs-devel@m.gmane.org; Sun, 04 Jul 2010 20:06:56 -0400 Original-Received: from [140.186.70.92] (port=36033 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OVZCz-0002qp-6f for emacs-devel@gnu.org; Sun, 04 Jul 2010 20:06:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OVZCw-0000MM-8G for emacs-devel@gnu.org; Sun, 04 Jul 2010 20:06:47 -0400 Original-Received: from mail-bw0-f41.google.com ([209.85.214.41]:60807) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OVZCN-0000Im-LI; Sun, 04 Jul 2010 20:06:11 -0400 Original-Received: by bwz9 with SMTP id 9so3146262bwz.0 for ; Sun, 04 Jul 2010 17:06:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=e47ahecfVwU94dG2PBy8LkyIulE07mVBM6CUK+3yvrc=; b=anr4nn5TckTTSWjU+ig5io2ej7tAMs+OpXSrW+80qE2zV7spn4liQ/pFzAt/mMfgM7 Sh/zTbAnUZLfWuxbocmP0HWvzE+oc5qDfBd3P8tspI1TvQoww8zpary+AuT24szm9xQc J4E6+6naqP9Rtv0+Qe6YBPbIcR/BejPs6oq/4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=etTNgWT61NBoYO4Gw5kPvW7SLUm6XXAGh/9kKhclB80VAucueQFaRoPt1hOjLjRsrT QhC89J9w64UcZDKJXiMf0ZIZfVE4wHc+YUfVsGRbwWI2657iqKmZWy1e42fUov5MTVDE iUMIdVMhI4tXY1TJftj1IIbwwTRVv4EhRw4iA= Original-Received: by 10.204.47.38 with SMTP id l38mr1379581bkf.154.1278288370229; Sun, 04 Jul 2010 17:06:10 -0700 (PDT) Original-Received: by 10.204.53.204 with HTTP; Sun, 4 Jul 2010 17:05:50 -0700 (PDT) In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126773 Archived-At: On Mon, Jul 5, 2010 at 01:58, Juanma Barranquero wrote: > This patch includes your original changes for buffer.c, keyboard.c, > process.c and xdisp.c, plus a few fixes. With them, they compile > correctly on my system. Correction: please add the "volatile" keyword to arg 3 of `keyremap_step': keyremap_step (Lisp_Object *keybuf, int bufsize, volatile keyremap *fkey, int input, int doit, int *diff, Lisp_Object prompt) Or, alternatively: does anyone know why read_key_sequence does have a ton of `volatile' variables? Do really all of then need to be volatile? Juanma