From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kyle Hargraves Newsgroups: gmane.emacs.bugs Subject: bug#6147: 23.2; ido-read-buffer regression Date: Sun, 9 May 2010 18:13:36 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=0015175907dc2085a504863171af X-Trace: dough.gmane.org 1273449400 10498 80.91.229.12 (9 May 2010 23:56:40 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 9 May 2010 23:56:40 +0000 (UTC) Cc: 6147@debbugs.gnu.org To: Juanma Barranquero Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 10 01:56:38 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OBGMN-0000OG-Qk for geb-bug-gnu-emacs@m.gmane.org; Mon, 10 May 2010 01:56:38 +0200 Original-Received: from localhost ([127.0.0.1]:58518 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBGML-0008KC-Uq for geb-bug-gnu-emacs@m.gmane.org; Sun, 09 May 2010 19:56:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1OBGMF-0008Jt-Oa for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:56:27 -0400 Original-Received: from [140.186.70.92] (port=56261 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OBGME-0008Jd-6C for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:56:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OBGMC-0002Gc-75 for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:56:26 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:48061) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBGMB-0002GU-N0 for bug-gnu-emacs@gnu.org; Sun, 09 May 2010 19:56:24 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OBGLr-0007Y6-1v; Sun, 09 May 2010 19:56:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kyle Hargraves Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 09 May 2010 23:56:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6147 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6147-submit@debbugs.gnu.org id=B6147.127344932029007 (code B ref 6147); Sun, 09 May 2010 23:56:03 +0000 Original-Received: (at 6147) by debbugs.gnu.org; 9 May 2010 23:55:20 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBGL9-0007Xi-3h for submit@debbugs.gnu.org; Sun, 09 May 2010 19:55:20 -0400 Original-Received: from mail-bw0-f214.google.com ([209.85.218.214]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OBFgq-0007Hi-T5 for 6147@debbugs.gnu.org; Sun, 09 May 2010 19:13:42 -0400 Original-Received: by bwz6 with SMTP id 6so1418095bwz.39 for <6147@debbugs.gnu.org>; Sun, 09 May 2010 16:13:36 -0700 (PDT) Original-Received: by 10.204.5.140 with SMTP id 12mr1963019bkv.34.1273446816318; Sun, 09 May 2010 16:13:36 -0700 (PDT) Original-Received: by 10.204.77.18 with HTTP; Sun, 9 May 2010 16:13:36 -0700 (PDT) In-Reply-To: X-Mailman-Approved-At: Sun, 09 May 2010 19:55:16 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 09 May 2010 19:56:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36811 Archived-At: --0015175907dc2085a504863171af Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, May 9, 2010 at 6:02 PM, Juanma Barranquero wrote= : > On Sun, May 9, 2010 at 22:06, Kyle Hargraves wrote: > > > This can be reproduced by evaluating: > > (ido-read-buffer "Buffer: " "nonexistent-buffer") > > In 23.2, you will see only a list of your current buffers. In 23.1, > > nonexistent-buffer is the default value. > > Yes, it has changed. > > > I believe the related commit may be: > > > http://github.com/emacsmirror/emacs/commit/e2300713fd5a941bfe1dad338b88f4= caf77cc945 > > Why do you believe that? > I misread it and thought it was introducing the buffer-live-p check. > The "culprit" is this change: > > ------------------------------------------------------------ > revno: 99373 > author: =D3scar Fuentes > committer: Juanma Barranquero > branch nick: trunk > timestamp: Mon 2010-01-18 20:34:55 +0100 > message: > ido.el: Consider the possibility of buffer names changing after > kill-buffer. > > which includes this: > > (ido-make-buffer-list): If "default" is a nonexistent > buffer, ignore it, as per the docstring. > > > =3D=3D=3D modified file 'lisp/ido.el' > --- lisp/ido.el 2010-01-13 08:35:10 +0000 > +++ lisp/ido.el 2010-01-18 19:34:55 +0000 > @@ -3344,7 +3344,7 @@ > (if ido-temp-list > (nconc ido-temp-list ido-current-buffers) > (setq ido-temp-list ido-current-buffers)) > - (if default > + (if (and default (buffer-live-p (get-buffer default))) > (progn > (setq ido-temp-list > (delete default ido-temp-list)) > > > Now, though `ido-make-buffer-list' has not exactly a docstring, but a > comment, it really says: > > ;; [...] If DEFAULT is non-nil, and corresponds to an existing buffer, > ;; it is put to the start of the list. > > so the use you did of it was relying on undocumented behaviour. > > Whether it should work as you prefer or not, I have no comment; but > there has been some recent discussion on emacs-devel about reverting > this patch and replacing it with another fix, by Leo (see thread > titled "PATCH: Fix IDO interaction with uniquify.el"); so perhaps you > can chime in with your thoughts. Thank you, I will look for it. > > Juanma > --0015175907dc2085a504863171af Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Sun, May 9, 2010 at 6:02 PM, Juanma Barranquero <lekktu@gmail.com> wrote:
On Sun, May 9, 2010 at 22:06, Kyle Hargraves <pd@krh.me> wrote:

> This can be reproduced by evaluating:
> (ido-read-buffer "Buffer: " "nonexistent-buffer")<= br> > In 23.2, you will see only a list of your current buffers. In 23.1, > nonexistent-buffer is the default value.

Yes, it has changed.

> I believe the related commit may be:
> http://github.com/emacsmirror/e= macs/commit/e2300713fd5a941bfe1dad338b88f4caf77cc945

Why do you believe that?

I misread it a= nd thought it was introducing the buffer-live-p check.
=A0
<= blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px= #ccc solid;padding-left:1ex;"> The "culprit" is this change:

=A0------------------------------------------------------------
=A0revno: 99373
=A0author: =D3scar Fuentes <ofv@wanad= oo.es>
=A0committer: Juanma Barranquero <l= ekktu@gmail.com>
=A0branch nick: trunk
=A0timestamp: Mon 2010-01-18 20:34:55 +0100
=A0message:
=A0 =A0ido.el: Consider the possibility of buffer names changing after kil= l-buffer.

which includes this:

=A0 =A0 =A0 =A0(ido-make-buffer-list): If "default" is a nonexis= tent
=A0 =A0 =A0 =A0buffer, ignore it, as per the docstring.


=3D=3D=3D modified file 'lisp/ido.el'
--- lisp/ido.el 2010-01-13 08:35:10 +0000
+++ lisp/ido.el 2010-01-18 19:34:55 +0000
@@ -3344,7 +3344,7 @@
=A0 =A0 (if ido-temp-list
=A0 =A0 =A0 =A0(nconc ido-temp-list ido-current-buffers)
=A0 =A0 =A0 (setq ido-temp-list ido-current-buffers))
- =A0 =A0(if default
+ =A0 =A0(if (and default (buffer-live-p (get-buffer default)))
=A0 =A0 =A0 =A0(progn
=A0 =A0 =A0 =A0 =A0(setq ido-temp-list
=A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0(delete default ido-temp-list))


Now, though `ido-make-buffer-list' has not exactly a docstring, but a comment, it really says:

=A0;; [...] =A0If DEFAULT is non-nil, and corresponds to an existing buffe= r,
=A0;; it is put to the start of the list.

so the use you did of it was relying on undocumented behaviour.

Whether it should work as you prefer or not, I have no comment; but
there has been some recent discussion on emacs-devel about reverting
this patch and replacing it with another fix, by Leo (see thread
titled "PATCH: Fix IDO =A0interaction with uniquify.el"); so perh= aps you
can chime in with your thoughts.

Thank you,= I will look for it.
=A0

=A0 Juanma

--0015175907dc2085a504863171af--