From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#6300: browse-url-encode need to encode more Date: Sat, 29 May 2010 13:29:21 +0200 Message-ID: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Trace: dough.gmane.org 1275156542 16149 80.91.229.12 (29 May 2010 18:09:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 29 May 2010 18:09:02 +0000 (UTC) To: 6300@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat May 29 20:09:01 2010 connect(): No such file or directory Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OIQOD-0004BA-PA for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 May 2010 20:09:00 +0200 Original-Received: from localhost ([127.0.0.1]:54404 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIQME-00075k-JE for geb-bug-gnu-emacs@m.gmane.org; Sat, 29 May 2010 14:02:02 -0400 Original-Received: from [140.186.70.92] (port=49616 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIOPw-0003ft-Cv for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 11:57:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OIOPr-00056f-8a for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 11:57:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46061) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIOPr-00056S-4L for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 11:57:39 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1OIODf-0001D8-6Y; Sat, 29 May 2010 11:45:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 29 May 2010 15:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 6300 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: Emacs Bugs Original-Received: via spool by submit@debbugs.gnu.org id=B.12751479004632 (code B ref -1); Sat, 29 May 2010 15:45:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 29 May 2010 15:45:00 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIODb-0001Cf-IV for submit@debbugs.gnu.org; Sat, 29 May 2010 11:44:59 -0400 Original-Received: from mail.gnu.org ([199.232.76.166] helo=mx10.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIODY-0001CZ-79 for submit@debbugs.gnu.org; Sat, 29 May 2010 11:44:57 -0400 Original-Received: from lists.gnu.org ([199.232.76.165]:37505) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OIODT-0008Kr-Bq for submit@debbugs.gnu.org; Sat, 29 May 2010 11:44:51 -0400 Original-Received: from [140.186.70.92] (port=48427 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OIODN-00033L-CG for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 11:44:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OIKEY-0006wn-5T for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 07:29:43 -0400 Original-Received: from mail-yw0-f193.google.com ([209.85.211.193]:55682) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OIKEX-0006wf-VF for bug-gnu-emacs@gnu.org; Sat, 29 May 2010 07:29:42 -0400 Original-Received: by ywh31 with SMTP id 31so1692917ywh.24 for ; Sat, 29 May 2010 04:29:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=SRx6NIb4t3QyzfyU+tQ4aDJAJ5d7ztFsOheNFT3kNF0=; b=Ase6AbXB4ia+QivGOJ76sBFL9vx292mktY+FoHbC1DDyE0G23bIWruLSIsDV9lWMZo u2cPTCwypvRPWKXw639+2Vx4jyrcB6jYOx7h6jBpmJhdtrhC/jjxfH/ytf4NLbhjICjs uVJGGij7kHLlJvYD1YjCY9Xlm4WFGElzcUohc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=aqGISu5D5Ks8duUkpDhD1OCpXxaOKozXDx9DlM0E72S6yra8QGCuE3Y3BDPodv/czk o1BC+ZkUCzp39bWUjzQTvKt5Maw+FyLd0NltSuIbptnQjUa3XAoZjmJ9wnWBYOnHS2s1 GcscclU/2JaIhWg8+8lw9EPGIYLb53BFfM/m8= Original-Received: by 10.100.245.40 with SMTP id s40mr2143811anh.137.1275132581230; Sat, 29 May 2010 04:29:41 -0700 (PDT) Original-Received: by 10.100.44.20 with HTTP; Sat, 29 May 2010 04:29:21 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 29 May 2010 11:45:03 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:37392 Archived-At: The character ?" needs to be escaped at least on w32 because otherwise ShellExecute will not work. Maybe this part of the patch should be platform specific, I do not know. Both Google Chrome and Firefox still thinks that it is good manner to also escape blanks as ?+. I suggest the following patch (this is agains a checkout from 2010-05-22): === modified file 'lisp/net/browse-url.el' --- trunk/lisp/net/browse-url.el 2010-04-29 14:04:33 +0000 +++ patched/lisp/net/browse-url.el 2010-05-29 10:52:33 +0000 @@ -634,7 +634,8 @@ ;; FIXME: Is there an actual example of a web browser getting ;; confused? (This used to encode commas, but at least Firefox ;; handles commas correctly and doesn't accept encoded commas.) - (browse-url-url-encode-chars url "[)$]")) + (replace-regexp-in-string " " "+" + (browse-url-url-encode-chars url "[\"()$]")))