From: Lennart Borgman <lennart.borgman@gmail.com>
To: 6300@debbugs.gnu.org
Subject: bug#6300: browse-url-encode need to encode more
Date: Sat, 29 May 2010 13:29:21 +0200 [thread overview]
Message-ID: <AANLkTik5HDDHXRF0unBq-En9gLDL5xG2gwNCKLb7MuFk@mail.gmail.com> (raw)
The character ?" needs to be escaped at least on w32 because otherwise
ShellExecute will not work. Maybe this part of the patch should be
platform specific, I do not know.
Both Google Chrome and Firefox still thinks that it is good manner to
also escape blanks as ?+.
I suggest the following patch (this is agains a checkout from 2010-05-22):
=== modified file 'lisp/net/browse-url.el'
--- trunk/lisp/net/browse-url.el 2010-04-29 14:04:33 +0000
+++ patched/lisp/net/browse-url.el 2010-05-29 10:52:33 +0000
@@ -634,7 +634,8 @@
;; FIXME: Is there an actual example of a web browser getting
;; confused? (This used to encode commas, but at least Firefox
;; handles commas correctly and doesn't accept encoded commas.)
- (browse-url-url-encode-chars url "[)$]"))
+ (replace-regexp-in-string " " "+"
+ (browse-url-url-encode-chars url "[\"()$]")))
next reply other threads:[~2010-05-29 11:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-29 11:29 Lennart Borgman [this message]
2011-09-21 20:23 ` bug#6300: browse-url-encode need to encode more Lars Magne Ingebrigtsen
2011-09-21 20:42 ` Lennart Borgman
2011-09-21 20:59 ` Lars Magne Ingebrigtsen
2012-05-09 12:40 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AANLkTik5HDDHXRF0unBq-En9gLDL5xG2gwNCKLb7MuFk@mail.gmail.com \
--to=lennart.borgman@gmail.com \
--cc=6300@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.