From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.bugs Subject: bug#7726: reveal-mode bypassed by compile-goto-error Date: Mon, 24 Jan 2011 21:09:29 +0100 Message-ID: References: <87vd2jb5e2.fsf@tux.homenetwork> <87vd1gbiwt.fsf@stupidchicken.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1295900732 5963 80.91.229.12 (24 Jan 2011 20:25:32 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 24 Jan 2011 20:25:32 +0000 (UTC) Cc: Chong Yidong , 7726@debbugs.gnu.org, Thierry Volpiatto To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Jan 24 21:25:27 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PhSyd-0003k2-HT for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jan 2011 21:25:27 +0100 Original-Received: from localhost ([127.0.0.1]:43799 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhSyc-0007Xd-WE for geb-bug-gnu-emacs@m.gmane.org; Mon, 24 Jan 2011 15:25:27 -0500 Original-Received: from [140.186.70.92] (port=60784 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PhSyE-0007Np-SM for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2011 15:25:03 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PhSyB-00065v-Lr for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2011 15:25:02 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:40778) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PhSyB-00065q-K5 for bug-gnu-emacs@gnu.org; Mon, 24 Jan 2011 15:24:59 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PhSby-0000d8-2t; Mon, 24 Jan 2011 15:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lennart Borgman Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 24 Jan 2011 20:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7726 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7726-submit@debbugs.gnu.org id=B7726.12958993112406 (code B ref 7726); Mon, 24 Jan 2011 20:02:01 +0000 Original-Received: (at 7726) by debbugs.gnu.org; 24 Jan 2011 20:01:51 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PhSbn-0000ck-0V for submit@debbugs.gnu.org; Mon, 24 Jan 2011 15:01:51 -0500 Original-Received: from mail-ew0-f44.google.com ([209.85.215.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PhSbk-0000cW-Na for 7726@debbugs.gnu.org; Mon, 24 Jan 2011 15:01:49 -0500 Original-Received: by ewy8 with SMTP id 8so2344245ewy.3 for <7726@debbugs.gnu.org>; Mon, 24 Jan 2011 12:09:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=UtEdauX2QmKAMTL0wM9OizF7merZubMkREvIpL2gA8M=; b=kTIsFUsfAN8UAG20h9kbMlUcintU9mTNq8HccZCbicDweqxFqbibyvX/B3YLmtX4e5 lGgXyv6wmFKx+AtJsfGJTb6m6hjTJ5SACone4Tq1xPIHueDRJbUcQMC6SIMWSIpxGdJp FfzpQH44t6V+Ctwgy96GIMEgVModBQ7HGTlDk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=KBbum2suFHSGl+HLqVTNTz7HdIfLFirpTlCAFma/XuW9uakQMQhAE0MMtOumqG1EUS tDD5Quy+4ZITatZHMJOISauAxHgflAkuEkJqYXtchYBfs430ZXkSwsp0FbWKhawafAv6 gA/nZZFmdDqSRiyisrg2tlfOa1Vij9I7VfL6I= Original-Received: by 10.213.35.147 with SMTP id p19mr5562898ebd.19.1295899790109; Mon, 24 Jan 2011 12:09:50 -0800 (PST) Original-Received: by 10.213.20.148 with HTTP; Mon, 24 Jan 2011 12:09:29 -0800 (PST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Mon, 24 Jan 2011 15:02:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:43612 Archived-At: On Mon, Jan 24, 2011 at 5:12 PM, Stefan Monnier wrote: >>>>>> If I use compile-goto-error from a grep-mode buffer to a org-mode >>>>>> buffer where the destination line is in a hidden outline then the >>>>>> outline will not be revealed until after next command. >>>>> also, goto-line is unable to reach line in an outline based buffer. >>>>> See in anything and ioccur, it is fixed for org-mode and >>>>> outline-minor-mode. >>>>> Is there other modes based on outline to handle? >>>> Anyone have a test case? >>> I think the problem is that reveal-mode runs from post-command-hook and >>> reveals what's in the buffer that's current when post-command-hook is >>> run, whereas in the above cases, the buffer that needs revealing is not >>> current at that point. >>> That's one of the cases where we could use something like >>> a "pre-redisplay-hook". >> Isn't it more like post-post-command-hook? > > No I really meant pre-redisplay-hook. =C2=A0I don't see why > post-post-command-hook would have anything to do with this problem. > E.g. I think a case that needs to work is when you're in the *compile* > buffer and select one entry to display the source but while staying in > the *compile* buffer: the current buffer before and after the command is > *compile*, so no amount of post/pre-command-hooks can tell you that some > other buffer needs revealing. Oh, I see. And haven't we been discussing before that such a hook maybe could be useful for cases where we now are using window-configuration-change-hook?