From: Tim Van Holder <tim.vanholder@gmail.com>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: 7905@debbugs.gnu.org
Subject: bug#7905: 24.0.50; VC not updating file status properly anymore after commit from vc-dir
Date: Mon, 31 Jan 2011 14:59:00 +0100 [thread overview]
Message-ID: <AANLkTi=bTn6v4ZqZ28c2g-SdNpnUqm23mLkByns4CLyH@mail.gmail.com> (raw)
In-Reply-To: <m3k4hlwei6.fsf@linux-m68k.org>
On 31 January 2011 11:31, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Tim Van Holder <tim.vanholder@gmail.com> writes:
>
>> $ grep foo CVS/Entries
>> /foo/1.297.2.24/Mon Jan 31 08:30:58 2011//Tmytag
>> $ stat foo
>> Modify: 2011-01-31 09:30:58.000000000 +0100
>
> Those are the same time stamp.
>
> Andreas.
Yes, but they end up not comparing as equal in VC.
Given a similar file but with CVS/Entries having "Tue Jan 11 15:18:16
2011" and stat giving "2011-01-11 16:18:16 +0100", edebugging
vc-cvs-parse-entry gets:
"time" as "Tue Jan 11 15:18:16 2011" (from matching its CVS/Entries line).
"mtime" as (19756 29880) (from "(nth 5 (file-attributes <file>))")
"parsed-time" as (16 18 15 11 1 2011 2 nil 0) (from parse-time on
value of "time")
It then has a check
(equal mtime (apply 'encode-time parsed-time))
which returns nil; the apply yields (19756 26280), which is indeed not
the same as (19756 29880).
Checking the behaviour of (encode-time) I see that
(encode-time 16 18 15 11 1 2011 2 nil 3600)
(encode-time 16 18 15 11 1 2011 2 nil 0)
both return the same value "(19756 26280)" (which decodes as "(16 18
15 11 1 2011 2 nil 3600)").
This strikes me as odd since encode-time explicitly says that it
treats the last argument as timezone offset, suggesting that it cares
about it.
next prev parent reply other threads:[~2011-01-31 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-24 10:48 bug#7905: 24.0.50; VC not updating file status properly anymore after commit from vc-dir Tim Van Holder
2011-01-25 0:48 ` Glenn Morris
2011-01-25 8:00 ` Tim Van Holder
2011-01-25 9:44 ` Tim Van Holder
2011-01-25 11:30 ` Tim Van Holder
2011-01-26 4:25 ` Glenn Morris
2011-01-26 9:44 ` Tim Van Holder
2011-01-26 10:07 ` Tim Van Holder
2011-01-27 7:25 ` Glenn Morris
2011-01-27 9:51 ` Tim Van Holder
2011-01-28 18:16 ` Glenn Morris
2011-01-31 9:06 ` Tim Van Holder
2011-01-31 10:31 ` Andreas Schwab
2011-01-31 13:59 ` Tim Van Holder [this message]
2011-01-31 14:10 ` Andreas Schwab
2011-02-01 10:18 ` Tim Van Holder
2011-02-01 21:45 ` Glenn Morris
2011-02-02 11:40 ` Tim Van Holder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=bTn6v4ZqZ28c2g-SdNpnUqm23mLkByns4CLyH@mail.gmail.com' \
--to=tim.vanholder@gmail.com \
--cc=7905@debbugs.gnu.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.