question about agendas

question about agendas

[Filippo A. Salustri]

Hi all,
I'm looking to customize how some agenda commands work.
The simple example I'm working on is combining changing a task's
priority AND refreshing the agenda.

What I'd normally do is:
1. cursor to the task of interest,
2. change its priority,
3. refresh the agenda.

After step 3, the cursor remains where it was in step 2.  That's fine.

Then I rebind , in org-agenda-mode-map to this:
(defun org-fas-agenda-priority (&optional p)
  "Change the priority of the current item, then refresh agenda."
  (interactive)
  (save-excursion
    (if (org-agenda-priority p)
	(org-agenda-redo))))

When this function runs, it does exactly what I want it to do.

BUT the cursor jumps to row one of the agenda buffer.

Can anyone suggest a cause and a fix?

Cheers.
Fil

-- 
Filippo A. Salustri, Ph.D., P.Eng.
Mechanical and Industrial Engineering
Ryerson University
350 Victoria St, Toronto, ON
M5B 2K3, Canada
Tel: 416/979-5000 ext 7749
Fax: 416/979-5265
Email: salustri@ryerson.ca
http://deseng.ryerson.ca/~fil/

Re: question about agendas

[Nick Dokos]

Filippo A. Salustri <salustri@ryerson.ca> wrote:

> Hi all,
> I'm looking to customize how some agenda commands work.
> The simple example I'm working on is combining changing a task's
> priority AND refreshing the agenda.
> 
> What I'd normally do is:
> 1. cursor to the task of interest,
> 2. change its priority,
> 3. refresh the agenda.
> 
> After step 3, the cursor remains where it was in step 2.  That's fine.
> 
> Then I rebind , in org-agenda-mode-map to this:
> (defun org-fas-agenda-priority (&optional p)
>   "Change the priority of the current item, then refresh agenda."
>   (interactive)
>   (save-excursion
>     (if (org-agenda-priority p)
> 	(org-agenda-redo))))
> 
> When this function runs, it does exactly what I want it to do.
> 
> BUT the cursor jumps to row one of the agenda buffer.
> 
> Can anyone suggest a cause and a fix?
> 

I don't understand it yet, but can you try without the save-excursion
and see if it does what you want?

Nick

Re: question about agendas

[Filippo A. Salustri]

Nick,
Thanks for the quick reply.

I'd actually started with a similar wrapper for org-priority, and the
save-excursion was needed because the org-agenda-redo would punt me
into the agenda from whatever other buffer I was in.

I carried the save-excursion into the agenda version of the function
because I thought it couldn't hurt.

Apparently it does.

Removing the save-excursion from the defun below fixes the cursor problem.
...could it be because the excursion is saved before the agenda buffer
is rebuilt?

Anyways, it's fixed, so I'm happy.
Thanks!
Cheers.
Fil

On 31 March 2011 14:51, Nick Dokos <nicholas.dokos@hp.com> wrote:
> Filippo A. Salustri <salustri@ryerson.ca> wrote:
>
>> Hi all,
>> I'm looking to customize how some agenda commands work.
>> The simple example I'm working on is combining changing a task's
>> priority AND refreshing the agenda.
>>
>> What I'd normally do is:
>> 1. cursor to the task of interest,
>> 2. change its priority,
>> 3. refresh the agenda.
>>
>> After step 3, the cursor remains where it was in step 2.  That's fine.
>>
>> Then I rebind , in org-agenda-mode-map to this:
>> (defun org-fas-agenda-priority (&optional p)
>>   "Change the priority of the current item, then refresh agenda."
>>   (interactive)
>>   (save-excursion
>>     (if (org-agenda-priority p)
>>       (org-agenda-redo))))
>>
>> When this function runs, it does exactly what I want it to do.
>>
>> BUT the cursor jumps to row one of the agenda buffer.
>>
>> Can anyone suggest a cause and a fix?
>>
>
> I don't understand it yet, but can you try without the save-excursion
> and see if it does what you want?
>
> Nick
>



-- 
Filippo A. Salustri, Ph.D., P.Eng.
Mechanical and Industrial Engineering
Ryerson University
350 Victoria St, Toronto, ON
M5B 2K3, Canada
Tel: 416/979-5000 ext 7749
Fax: 416/979-5265
Email: salustri@ryerson.ca
http://deseng.ryerson.ca/~fil/