* bug#7309: [patch] make emacs compile with clang
@ 2010-11-01 0:54 Elias Pipping
2010-11-01 2:02 ` Stefan Monnier
0 siblings, 1 reply; 2+ messages in thread
From: Elias Pipping @ 2010-11-01 0:54 UTC (permalink / raw)
To: 7309
[-- Attachment #1: Type: text/plain, Size: 294 bytes --]
Hi,
(given the combination of configure options that I use), emacs fails
to compile for me because of a single issue that is easily fixed: two
functions in oldXMenu don't specify a return type. Apparently, it
should be void in both cases. I've attached a patch.
Kind regards,
Elias Pipping
[-- Attachment #2: emacs-23.2-clang.patch --]
[-- Type: text/x-patch, Size: 736 bytes --]
Source: Elias Pipping <pipping@exherbo.org>
Upstream: no
Reason: The return type should be void, not int
--- emacs-23.2/oldXMenu/XDelAssoc.c
+++ emacs-23.2/oldXMenu/XDelAssoc.c
@@ -17,6 +17,7 @@
* an XId. An association may be removed only once. Redundant
* deletes are meaningless (but cause no problems).
*/
+void
XDeleteAssoc(dpy, table, x_id)
register Display *dpy;
register XAssocTable *table;
--- emacs-23.2/oldXMenu/XMakeAssoc.c
+++ emacs-23.2/oldXMenu/XMakeAssoc.c
@@ -27,6 +27,7 @@
* meaningless (but cause no problems). The queue in each association
* bucket is sorted (lowest XId to highest XId).
*/
+void
XMakeAssoc(dpy, table, x_id, data)
register Display *dpy;
register XAssocTable *table;
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#7309: [patch] make emacs compile with clang
2010-11-01 0:54 bug#7309: [patch] make emacs compile with clang Elias Pipping
@ 2010-11-01 2:02 ` Stefan Monnier
0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2010-11-01 2:02 UTC (permalink / raw)
To: Elias Pipping
> (given the combination of configure options that I use), emacs fails
> to compile for me because of a single issue that is easily fixed: two
> functions in oldXMenu don't specify a return type. Apparently, it
> should be void in both cases. I've attached a patch.
Thanks, installed in the emacs-23 branch.
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-01 2:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 0:54 bug#7309: [patch] make emacs compile with clang Elias Pipping
2010-11-01 2:02 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.