all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Elias Pipping <pipping.elias@googlemail.com>
To: 7309@debbugs.gnu.org
Subject: bug#7309: [patch] make emacs compile with clang
Date: Mon, 1 Nov 2010 01:54:37 +0100	[thread overview]
Message-ID: <AANLkTi=PJVZ_GoxdhAe7mQmToyrxo60SbcJB+bA2aV2Q@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

Hi,

(given the combination of configure options that I use), emacs fails
to compile for me because of a single issue that is easily fixed: two
functions in oldXMenu don't specify a return type. Apparently, it
should be void in both cases. I've attached a patch.


Kind regards,

Elias Pipping

[-- Attachment #2: emacs-23.2-clang.patch --]
[-- Type: text/x-patch, Size: 736 bytes --]

Source: Elias Pipping <pipping@exherbo.org>
Upstream: no
Reason: The return type should be void, not int
--- emacs-23.2/oldXMenu/XDelAssoc.c
+++ emacs-23.2/oldXMenu/XDelAssoc.c
@@ -17,6 +17,7 @@
  * an XId.  An association may be removed only once.  Redundant
  * deletes are meaningless (but cause no problems).
  */
+void
 XDeleteAssoc(dpy, table, x_id)
         register Display *dpy;
 	register XAssocTable *table;
--- emacs-23.2/oldXMenu/XMakeAssoc.c
+++ emacs-23.2/oldXMenu/XMakeAssoc.c
@@ -27,6 +27,7 @@
  * meaningless (but cause no problems).  The queue in each association
  * bucket is sorted (lowest XId to highest XId).
  */
+void
 XMakeAssoc(dpy, table, x_id, data)
 	register Display *dpy;
 	register XAssocTable *table;

             reply	other threads:[~2010-11-01  0:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-01  0:54 Elias Pipping [this message]
2010-11-01  2:02 ` bug#7309: [patch] make emacs compile with clang Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='AANLkTi=PJVZ_GoxdhAe7mQmToyrxo60SbcJB+bA2aV2Q@mail.gmail.com' \
    --to=pipping.elias@googlemail.com \
    --cc=7309@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.