From: Joe Matarazzo <joe.matarazzo@gmail.com>
To: 7446@debbugs.gnu.org
Subject: bug#7446: Emacs 23.2 [windows] - Buffer overrun bug with ebrowse.exe
Date: Fri, 19 Nov 2010 16:39:49 -0800 [thread overview]
Message-ID: <AANLkTi=Dsc22Lcn0Qqdn3S-Qq3DDDK=7s_TU9ctRg_vW@mail.gmail.com> (raw)
When the input file ends with a C++ style "//" comment line, without a
newline at the end, the parser will attempt to read past the end of
the input buffer. This produces undefined results, among them putting
the parser in a bogus state that makes all subsequent input files
parse incorrectly. Here's a possible fix:
--- old/ebrowse.c 2010-04-03 15:26:07 -0700
+++ new/ebrowse.c 2010-11-19 16:36:13 -0800
@@ -1784,6 +1784,10 @@
case '/':
while (GET (c) && c != '\n')
;
+
+ if (c == 0)
+ return YYEOF;
+
INCREMENT_LINENO;
break;
I'm not subscribed to the list. Please direct any follow up questions
directly to my email.
Thanks,
Joe
next reply other threads:[~2010-11-20 0:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-20 0:39 Joe Matarazzo [this message]
2010-11-27 9:32 ` bug#7446: Emacs 23.2 [windows] - Buffer overrun bug with ebrowse.exe Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='AANLkTi=Dsc22Lcn0Qqdn3S-Qq3DDDK=7s_TU9ctRg_vW@mail.gmail.com' \
--to=joe.matarazzo@gmail.com \
--cc=7446@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.