bug#8379: The width of linum window is not adjusted after face-remapping

bug#8379: The width of linum window is not adjusted after face-remapping

[nixie]

Hi,

I am green hand in emacs, and starting using GNU Emacs since 23.1.

I found that the width of linum window is not changed with
(text-scale-increase) or (text-scale-decrease) function. 
This is annoying especially when I increase the text size, because the
line number can not be fully viewed.

currently, I use some alleviating code like below to solve this problem.
But I think it does not have generality.

Does someone have any good suggestion on it? Or it can be solved in a
more elegant and general way. I wish that it would be solved in future
version of GNU Emacs.
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;
(defun rescale-window-margin-by-faceremapping (win)
  (let ((width (car (window-margins)))
	(scale (cadr (assoc ':height 
			    (assoc 'default 
				   face-remapping-alist)))))
    (if (numberp scale)
	(progn
	  (set-window-margins win (ceiling (* width scale)) (cdr
(window-margins win)))
	  (force-window-update))
      nil)))

(defadvice linum-update-window (after scaling-margin-width last (win)
activate)
  (rescale-window-margin-by-faceremapping win)
  ad-return-value)
;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;

Thanks for any help.


-- 
nixie <onixie@gmail.com>

bug#8379: The width of linum window is not adjusted afterface-remapping

[Drew Adams]

> I found that the width of linum window is not changed with
> (text-scale-increase) or (text-scale-decrease) function. 
> This is annoying especially when I increase the text size, because the
> line number can not be fully viewed.

Yes, indeed.
http://www.emacswiki.org/emacs/face-remap%2b.el

bug#8379: The width of linum window is not adjusted after face-remapping

[Juanma Barranquero]

forcemerge 1255 8379
thanks

> I found that the width of linum window is not changed with
> (text-scale-increase) or (text-scale-decrease) function.

This is bug#1255: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1255

    Juanma

bug#8379: The width of linum window is not adjusted afterface-remapping

[Drew Adams]

> > I found that the width of linum window is not changed with
> > (text-scale-increase) or (text-scale-decrease) function.
> 
> This is bug#1255: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1255

Well if Emacs Dev now recognizes that this is a bug or a missing feature (Stefan
called the _lack_ of window resizing for text scaling "one of its greatest
features"), there's a simple solution.  I proposed it as soon as text scaling
was introduced, but it wasn't adopted.

http://www.emacswiki.org/emacs/face-remap%2b.el

This provides an option that allows for automatic resizing of the window, to go
along with text resizing.  That puts the behavior under user control.  The
window resizing can be: none, horizontal, vertical, or both.

And any function or mode (e.g. linum-mode) that needs a particular type of
window resizing can obviously bind or set the value locally.

This is a trivial fix.  It would be good if Emacs Dev gives users the choice.
Here is the original thread, with a patch:
http://lists.gnu.org/archive/html/emacs-devel/2009-08/msg00414.html

bug#8379: The width of linum window is not adjusted afterface-remapping

[Juanma Barranquero]

On Wed, Mar 30, 2011 at 15:19, Drew Adams <drew.adams@oracle.com> wrote:

> Well if Emacs Dev now recognizes that this is a bug or a missing feature

It is filed as a bug, that does not mean we all agree about its status.

> (Stefan
> called the _lack_ of window resizing for text scaling "one of its greatest
> features"),

Yes, but, if I'm reading correctly the old thread, he didn't say that
there wasn't a bug, only that the bug is not in text scaling, but in
applications (like linum) that can be affected for it and do not plan
accordingly.

    Juanma

bug#8379: The width of linum window is not adjusted afterface-remapping

[nixie]

> forcemerge 1255 8379
> thanks

>> I found that the width of linum window is not changed with
>> (text-scale-increase) or (text-scale-decrease) function.

> This is bug#1255: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=1255

Sorry for not kindly reading the threads archives.

> Yes, but, if I'm reading correctly the old thread, he didn't say that
> there wasn't a bug, only that the bug is not in text scaling, but in
> applications (like linum) that can be affected for it and do not plan
> accordingly.
> 
>     Juanma

yes, i think it is not a bug in text scaling. But i don't think fix it
in applications (maybe not only the linum) is a good idea. 

I wonder if there is a pure and smart window adjusting function.


-- 
nixie <onixie@gmail.com>

bug#8379: The width of linum window is not adjusted afterface-remapping

[Drew Adams]

> I wonder if there is a pure and smart window adjusting function.

Did you look at face-remap+.el?  In what way does it not adjust the window as
needed?

bug#8379: The width of linum window is not adjusted afterface-remapping

[Juanma Barranquero]

On Thu, Mar 31, 2011 at 11:31, nixie <onixie@gmail.com> wrote:

> Sorry for not kindly reading the threads archives.

No problem. It is often hard to find the relevant bug. In this case, I
remembered the old one because I was involved.

> yes, i think it is not a bug in text scaling. But i don't think fix it
> in applications (maybe not only the linum) is a good idea.

I'm not really sure. On one hand, it seems like text scaling should
affect all the window (margins, etc.). On the other hand, I understand
Stefan's comment that that's not what text-scaling is supposed to do.

    Juanma

bug#8379: The width of linum window is not adjusted afterface-remapping

[Drew Adams]

> > yes, i think it is not a bug in text scaling. But i don't 
> > think fix it in applications (maybe not only the linum)
> > is a good idea.
> 
> I'm not really sure. On one hand, it seems like text scaling should
> affect all the window (margins, etc.). On the other hand, I understand
> Stefan's comment that that's not what text-scaling is supposed to do.

There is no right or wrong answer wrt affecting the window that applies to all
contexts.  The behavior wrt the window should be under user and program control.
Sometimes you want the window to be resized to adapt to the apparent text size
change; sometimes you do not.

bug#8379: The width of linum window is not adjusted afterface-remapping

[Juanma Barranquero]

On Thu, Mar 31, 2011 at 16:48, Drew Adams <drew.adams@oracle.com> wrote:

> There is no right or wrong answer wrt affecting the window that applies to all
> contexts.  The behavior wrt the window should be under user and program control.
> Sometimes you want the window to be resized to adapt to the apparent text size
> change; sometimes you do not.

You're right that there's no right or wrong answer. What I meant is
that I don't know if what you call "program control" should be the
responsibility of the text-scaling code (with suitable hooks to allow
customization), or it's better to leave it as it is and let the
applications (like linum.el) adapt to a possible rescaling.

As it is now, an application has no way to know that the text in the
buffer is shown rescaled/remaped, unless it periodically checks
`face-remapping-alist', because remapping does not *have* to go
through face-remap-* functions, so there's no hook or callback.

    Juanma