From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Gabriel Santos via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74461: [PATCH] Add go-work-ts-mode Date: Sun, 22 Dec 2024 13:05:52 -0300 Message-ID: References: <87ttbzd16p.fsf@disroot.org> <86jzcl81py.fsf@gnu.org> <877c8l55he.fsf@disroot.org> <1C8B596E-785F-435D-AFEA-A2382FDA6AD8@disroot.org> Reply-To: Gabriel Santos Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25411"; mail-complaints-to="usenet@ciao.gmane.io" Cc: dev@rjt.dev, Eli Zaretskii , 74461@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Dec 22 17:07:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tPOUD-0006SS-9a for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 22 Dec 2024 17:07:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tPOTy-0006e3-0m; Sun, 22 Dec 2024 11:07:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tPOTu-0006dl-Hk for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:07:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tPOTu-00019b-4v for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:07:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:References:In-Reply-To:From:Date:To:Subject; bh=KgrFLoV8Ap8GddoPLY+lsmSEKieGsrgedNxeJaxcHWk=; b=Rg5xJqKjczNgLa0Jr5uMcxMC6xbVmAumn/a5e9cvuoO5ewDbRI6nY2nNASgS92LgFtRUa2OgxGQUiBJ6b4EUdRTLynkVewdpDvsjbprmrkU9rwViy+m8Mbb7JRBNGmXi/FNarpH3du01+Z6KbRsUdct/EzSlePpVhtOHIl5xZCQJTbXm2EJf2TGT96ceXrXMaenjK3JHOI3E1mFvd3owXSelvvlZcy6MGHE2v+MO9T9zXcrtiovwSxqke6y/0XogdZqpqir7PRzkfEYIp0WXF5kFTZoS4wzclxIKqywp1Hxh9uhA3wgUqJg/k3LyFvpOIKt8Q9Tv48l/ffKXOo4RfA==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tPOTt-0003rA-V7 for bug-gnu-emacs@gnu.org; Sun, 22 Dec 2024 11:07:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Gabriel Santos Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Dec 2024 16:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74461 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74461-submit@debbugs.gnu.org id=B74461.173488356914752 (code B ref 74461); Sun, 22 Dec 2024 16:07:01 +0000 Original-Received: (at 74461) by debbugs.gnu.org; 22 Dec 2024 16:06:09 +0000 Original-Received: from localhost ([127.0.0.1]:51597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPOT3-0003pr-3G for submit@debbugs.gnu.org; Sun, 22 Dec 2024 11:06:09 -0500 Original-Received: from layka.disroot.org ([178.21.23.139]:58210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tPOSx-0003pf-Ry for 74461@debbugs.gnu.org; Sun, 22 Dec 2024 11:06:07 -0500 Original-Received: from mail01.disroot.lan (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id B188F25B6C; Sun, 22 Dec 2024 17:06:01 +0100 (CET) X-Virus-Scanned: SPAM Filter at disroot.org Original-Received: from layka.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavis, port 10024) with ESMTP id gyJCT-xaksf0; Sun, 22 Dec 2024 17:05:57 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1734883557; bh=Qa30mwMorDMqPgm61Hd9jRpm7jR/yqGq0N7neRMGIik=; h=Date:From:To:CC:Subject:In-Reply-To:References; b=JBitl2UD+FTN+0EGoXGT/+pUQoax63DO8Y5Ap3M+qubTc4J26Q7/FxvsDcndOcnrV 9+WgG08K6Vdl5rggbJZje/W4a75EihjuDNwyOcqqIhWjyV7cKw4e++Y0vjDASJY+8s cjH3Dq8gIKWBceQl/JIqaxXAM7+R8Ee4cOiP4p5L1cz1RtH/Ys4pQ5MdTKU0T8KEb3 4tFsCkYNuKb6vbrIHyReNNylVrlKEIAvBCe0gkLgciYyB8pN7USEIPnoSPdzAofGhX dgIgWwkPyeJX/wmrwf6Hke9UsvwvgFRCuwNVKia1o37DuRxOQkDnBVA9da0FFHmkuz 4ox/6eS382E+g== In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:297606 Archived-At: >It was a kind of rethorical question: whether we do or not, we *should* >have such a mechanism and we should use it here=2E Oh definitely, another point for discussion=2E >> Go uses tabs for indentation, >> and spaces for alignment=2E >[=2E=2E=2E] >> The language specification doesn't mention >> that, but I think it should=2E >> Maybe I should send them an e-mail about that=2E > >I don't think the language cares (or should care)=2E It's only a convent= ion=2E > >But if it's the only convention in use in Go, that's fine: just add >a link to https://go=2Edev/doc/effective_go#formatting that justifies >the setting=2E I added it to the commentary section: +;; Go uses tabs as a convention for indentation: +;; https://go=2Edev/doc/effective_go#formatting +;; so indent-tabs-mode is enabled for the modes=2E >>>Since we don't have another (non-treesitter) mode for these files, I'd >>>recommend you go straight for: >>> >>> ;;;###autoload >>> (add-to-list 'auto-mode-alist '("/go\\=2Ework\\'" =2E go-work-ts-mo= de)) >> >> >> Sorry if I misunderstand, >> but that doesn't seem to be the case >> for other tree-sitter modes=2E > >Past practice does not always reflect best practices, especially when >talking about relatively new practices=2E I'll change that, but after this is accepted I'll make this change to the other modes, CCing emacs-devel and the respective maintainers=2E -- Gabriel Santos