From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: 73552@debbugs.gnu.org
Cc: "Gerd Möllmann" <gerd.moellmann@gmail.com>,
"Eli Zaretskii" <eliz@gnu.org>,
"Stefan Monnier" <monnier@iro.umontreal.ca>
Subject: bug#73552: obsolete (and broken) face attribute :reverse-video
Date: Sun, 29 Sep 2024 12:49:44 +0200 [thread overview]
Message-ID: <A9CA266B-0029-4B69-B3D4-1E5ECE0D6DEB@gmail.com> (raw)
The face attribute keyword :reverse-video has been broken in defface for a long time, and it's not used very much, so I added a compiler warning and a notice to NEWS.
This keyword along with :bold and :italic have been obsolete for longer than that and aren't even mentioned in any documentation (on purpose) but in the internal face-and-display machinery they still partly work.
I'm not quite sure why :reverse-video doesn't work in defface. Demo, in *scratch*:
(defface myface '((t :reverse-video t)) "my face")
(insert (propertize "bon bon" 'font-lock-face 'myface) ?\n)
=> bon bon ; not inverted
(insert (propertize "non non" 'font-lock-face '(:reverse-video t)) ?\n)
=> non non ; inverted
I first blamed a simple 14 years old mistake in `custom-fix-face-spec` but fixing that doesn't help, not sure why. But it means that we probably don't need to fix it, and indeed there are precious few packages using :reverse-video. One is make-mode.el; outside Emacs, I only found one (yaml-mode).
While :bold and :italic are obsolete as well, they are used a lot more (and actually seem to work) so I'm not warning about them now.
To summarise:
- Should we fix `custom-fix-face-spec`? Maybe, or just stop pretending that it handles :reverse-video.
- Should we bother to fix what other mechanism preventing :reverse-video from working? Probably no.
- Should we remove :reverse-video from the display machinery? Yes, but maybe not now?
- Should we remove :bold and :italic? Yes, but definitely not now.
next reply other threads:[~2024-09-29 10:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-29 10:49 Mattias Engdegård [this message]
2024-09-29 11:31 ` bug#73552: obsolete (and broken) face attribute :reverse-video Gerd Möllmann
2024-09-29 12:35 ` Mattias Engdegård
2024-09-29 12:55 ` Eli Zaretskii
2024-09-29 13:41 ` Mattias Engdegård
2024-09-29 13:49 ` Eli Zaretskii
2024-09-29 13:55 ` Stefan Kangas
2024-09-29 16:22 ` Mattias Engdegård
2024-09-29 16:42 ` Eli Zaretskii
2024-09-29 17:25 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=A9CA266B-0029-4B69-B3D4-1E5ECE0D6DEB@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=73552@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=gerd.moellmann@gmail.com \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.